Repository navigation
feat(cameras): live alignment score and lighting match against the reference frame - #151
Open
ravediamond wants to merge 1 commit into
Open
ravediamond wants to merge 1 commit into
ravediamond wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #139, as suggested there: the alignment score and lighting match from teleop-setup-align.
Once a camera has a reference frame, the recording dialog now shows under its controls:
Lighting 72% (brightness 7.0%, color 0.3%). Green at 85 or above, amber from 60, red below.How it works:
<video>pixels against the saved PNG, so the backend still never opens a camera. Both frames are raw stream frames, so rotation doesn't affect the comparison. No backend changes.–instead of a misleading number.Tests:
cameraReferenceScore.test.tschecks the port against numbers from the original OpenCV implementation on the same synthetic scenes (shift, brightness, color).CameraConfiguration.test.tsxcovers the score line and the border. The full frontend suite passes (59 tests), and eslint is clean on the touched files.Not yet checked: the browser version on the physical rig. The math matches the OpenCV tool, but I haven't run it on live cameras in LeLab.