Repository navigation
Conversation
… key A session the store hands back may not know its key until it has opened, as one with a preload does. getCore read opened.key to decide whether to reuse it, so a second read of the same core in the same tick compared against null and threw a TypeError. Two reads of a cold core in one tick are routine: the parallel walk fills every slot of a node at once. A restarted autobee hit it booting its system bee.
Contributor
|
(update corestore, you are out of date) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCoredecided whether to reuse an opened core by comparingopened.keywith the key it wants. A session the store hands back may not know its key until it has opened (one with a preload, for example), so a second read of the same core in the same tick compared againstnulland threwTypeError: Cannot read properties of null (reading 'buffer').Two reads of a cold core in one tick are routine, since the inflate walk fills every slot of a node at once. A restarted autobee hit this booting its system bee, and because it is a
TypeError, safety-catch rethrows it and the process exits.The context now remembers the key each core was opened with and compares against that. The test in
test/map-core.jsopens a bee through a store whose sessions learn their key late; it throws theTypeErrorbefore this change and passes after.