Repository navigation
the Computer pane switches a Bot to its own screen on a computer it shares, and back - #208
Merged
Merged
Conversation
hexuria
added a commit
that referenced
this pull request
Oct 11, 2026
…computer is on its own screen (#210) * the Computer pane drops the own-screen switch: every Bot on a shared computer is on its own screen Reverts #208. The server now puts every Bot that shares a computer on a screen of its own, with its own browser and profile, and has no route to switch it back (opengrok-server gol/own-screen-default), so the switch would do nothing. * the eye on a hovered screenshot sits in the middle of the picture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client half of hexuria/opengrok-server#376. The server half is hexuria/opengrok-server#383 (merge that first); the box half is hexuria/box#40 (merged).
What
CoworkerComputer.screen(own|shared), from opengrok-servercoworker_screen.Nonefrom a server before own screens, which hides the switch.OpenGrokClient::set_own_screen:PUT /coworkers/{id}/computer/screen {own}→ whether the Bot is on its own screen now (serverput_own_screen). A refusal, such as for a Bot with a computer of its own, comes back in the server's words.AppState::own_screen_offer/set_own_screen:shareScopeuser or org) and the server says which screen the Bot is on.computer-own-screen).computer-own-screenis a switch node, checked while the Bot is on its own screen and disabled while it is switching. Clicking it sendsSetOwnScreen(!own). The node is absent when nothing can be switched. Catalogued insrc/agent/mod.rs.The computer window already loads the server's
vncUrlper Bot, so it shows the Bot's own screen without change: the server's screen proxy routes it to that Bot's display.Tests
a_bot_is_put_on_its_own_screen_and_back(wiremock: one PUT each way;screenread, and absent from an older server).the_own_screen_switch_is_offered_on_a_shared_computer_only(user and org → offered and checked as reported; dedicated, group and noscreen→ not offered).cargo fmt --checkis clean. Both tests passed locally (cargo test --all-features own_screen). The full suite and both clippy gates run in CI.Live check to follow once #383 is merged and running on :1447: switch Bot B to its own screen, open Facebook in Bot A, and see that Bot B's screen does not show it.