Skip to content

ci(CI-CD): 👷 add one aggregating required status check - #107

Merged
baxyz merged 1 commit into
mainfrom
ci/required-status-check
Sep 24, 2026
Merged

baxyz merged 1 commit into
mainfrom
ci/required-status-check

Conversation

@baxyz

@baxyz baxyz commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a required job to pr-validation.yml that depends on every blocking job (conventional-commits, version-bump-check, test-features, test-scenarios, shellcheck) and fails if any of them failed or was cancelled.
  • Its check name, Required checks passed, is the one name to add as a required status check on the main ruleset — stable even though test-features/test-scenarios fan out into a matrix whose individual check names shift as it changes.

Why

The main ruleset (Settings → Rules → main) has pull_request, code_quality, deletion and non_fast_forward rules but no required_status_checks rule — nothing currently blocks a merge on red CI. Same gap found and fixed in helpers4/rust this week.

Test plan

  • CI green on this PR, then add Required checks passed as a required status check in the main ruleset.

🤖 Generated with Claude Code

Same fix as helpers4/rust: the ruleset on main has no required_status_checks rule yet, so
nothing actually blocks a merge on a red pr-validation.yml run. test-features and
test-scenarios each fan out into a matrix whose check names shift whenever the matrix changes,
which would make required checks listed individually go stale. This job depends on every
blocking job and fails if any of them failed or was cancelled. "Required checks passed" is the
one name to add in Settings -> Rules -> main -> Require status checks to pass.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

✅ PR Validation Passed

All checks passed!


📋 Pipeline Status

Job Status
✅ 🧾 Conventional Commits passing
✅ 🔖 Version Bump passing
✅ 🧪 Feature Tests passing
✅ 🧪 Scenario Tests passing
✅ 🐚 ShellCheck passing

🤖 Generated by @helpers4 CI • 2026-09-24

@baxyz
baxyz merged commit c9d1461 into main Sep 24, 2026
48 checks passed
@baxyz
baxyz deleted the ci/required-status-check branch September 24, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant