Repository navigation
chore(build): pin Node to a patched 24.x for the Toolforge build and CI - #661
Merged
Merged
Conversation
A WMCS security notice (2026-10) asks Node users on Toolforge to move to 22.23.4+, 24.22.1+ or 26.12.1+. Montage serves no Node at runtime (Procfile: gunicorn), but the Toolforge build (heroku/nodejs buildpack) uses Node to build the frontend. - package.json: engines.node ">=24.22.1 <25"; the buildpack picks the newest matching version. - CI (lint-frontend.yml): Node from the same engines.node via node-version-file (was 20), and a step that prints the version used. - CI (pr.yml): the frontend job also runs when package.json or a workflow changes, so a change like this one gets a build. - dev.md: Node 24, 24.22.1 or later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rsion check) From the pr-check of 5a1b42d: - package-lock.json (root): regenerated; npm records engines.node in the root entry. - pr.yml: workflow changes also run the backend tests (a change to test-backend.yml was skipped and counted as a pass); the root package-lock.json triggers the frontend job. - lint-frontend.yml: the version step fails when the Node in use is outside engines.node (semver -r) instead of only printing it; CI now installs and builds like the Toolforge build (npm ci, npm run toolforge:build). - dev.md: refers to engines.node instead of repeating the version, and notes that Node 24 is supported until 2028-04-30. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A WMCS security notice (2026-10) asks Node users on Toolforge to move to 22.23.4+, 24.22.1+ or 26.12.1+. Montage serves no Node at runtime (Procfile: gunicorn), but the Toolforge build (heroku/nodejs buildpack) uses Node to build the frontend.