Repository navigation
Claude/r3 simplification - #8
Merged
Merged
Conversation
Audit only. No production, QML, test or packaging change. UI findings come from captures of all 30 analysis pages plus Engine Design. Code findings come from duplicate scans, timing and an import profile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…(R3-A) - Remove the Compare, Charts and Gas Properties placeholder pages, their shared skeleton and three unused visuals. No status bar says "mock data"; the Equation Library carries its own reference note. - Navigation families name pages by key; unused per-domain lists removed. - RFIssueLine: an issue caused by a missing, stale, refused or mismatched upstream result shows an "Open <page>" button that only navigates (31 reviewed codes, pinned by tests/application/test_issue_links.py). - Oblique Shock opens on Relation; a table row still opens the Calculator. - Home describes every family; MockData keeps only what is still read. Two independent reviews: the first found 1 material issue, fixed; the confirmation review found 0 material. Base 9487 passed, 448 skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… units (R3-B) - Side panels that were empty or only said "Shown with a result" are hidden until there is one, so the inputs use the width. - Repeated "Nothing is computed until you do" sentences and the status bar's stateless warning dot are removed; scientific caveats stay. - Fluid Properties and Line take pressure in Pa, bar or MPa from one shared table (application/analysis/pressure_units.py, also used by Thermochemistry). Values are still stored and solved in pascals. - Fix: a unit switch showed the value at the old decimals (0.35 MPa as "0") and the next step wrote a wrong pressure; Thermochemistry too. - Fix: a step was written at 3 decimals whatever the field showed. Reviews: the first found 2 material issues, fixed; the confirmation review found 0 material. Base 9493 passed, 448 skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change, and why?
Which mode/area does it touch?
rocketforge/physics/,rocketforge/engineering/)ui/pages/)ui/engine/)If this touches physics: does it change a frozen contract's output or
tolerance? (See Known limitations and
Verification and freeze status.)
If yes, link the issue where this was discussed first — see
CONTRIBUTING.md.
Testing
pytest -qpasses locally (base suite)pytest -qpasses against the CEA-enabled environment, if this touchesthermochemistry/performance
Checklist
rocketforge/physics/compressible/change without a linked defectreport