Repository navigation
Adds new integration [ttiot/curingChamber] - #11574
Conversation
|
Thank you for submitting your repository to HACS (Home Assistant Community Store). Your submission is in the review queue: You can view the current queue here. Pull requests are processed in the order they were created, oldest first. What to avoid during review:
If you need to make changes: About draft pull requests: What happens next:
|
a36517b to
e786c73
Compare
frenck
left a comment
There was a problem hiding this comment.
Hi @ttiot, thanks for the submission! 👋
The weigh-in photo handling lets any logged-in user read files from the Home Assistant host. _photo_bytes in custom_components/curing_chamber/coordinator.py (lines 108-124) treats any string that points at an existing file as a path to read (os.path.isfile(photo), then open(photo, "rb")). That string comes straight from the record_weight and import_batch actions (services.py lines 144 and 121, photo and photo_data) and from the curing_chamber/weigh_in and curing_chamber/batch/import websocket commands (websocket.py lines 328-355 and 258-278). None of these are admin-only. A non-admin user can send photo: "/config/secrets.yaml" (or anything under .storage), the file is copied into the photo store, and curing_chamber/batch/export with include_photos: true hands it back base64 encoded.
The panel and the card already send data URLs, so the simplest fix is to drop the local path branch entirely. If you want to keep path support for the action, check it with hass.config.is_allowed_path(photo) first, and keep paths out of the websocket commands.
While you are at it: the README install section only describes adding a custom repository. Once this is in the default catalog, users can simply search for it in HACS, so lead with that.
Once that's addressed, push a new release and re-request review.
../Frenck
Blogging my personal ramblings at frenck.dev
Or subscribe to my free bi-weekly newsletter: frenck.dev/newsletter
|
Thanks for the review, and for the clear write-up. Fixed in v0.7.1 (PR ttiot/curingChamber#13):
The PR links above are updated to the new release and the latest action runs. @frenck, could you take another look when you have a moment? |
frenck
left a comment
There was a problem hiding this comment.
Hi @ttiot, thanks for the submission! 👋
Approving and merging now.
../Frenck
Blogging my personal ramblings at frenck.dev
Or subscribe to my free bi-weekly newsletter: frenck.dev/newsletter
|
Congratulations! Your repository has been added to HACS 🎉 Your repository has been approved: Resources: Thank you for contributing to the Home Assistant community! 🎉 |
Checklist
Links
Link to current release: https://github.com/ttiot/curingChamber/releases/tag/v0.7.1
Link to successful HACS action (without the
ignorekey): https://github.com/ttiot/curingChamber/actions/runs/39562079019Link to successful hassfest action (if integration): https://github.com/ttiot/curingChamber/actions/runs/39562078987