Skip to content

Adds new integration [ttiot/curingChamber] - #11574

Merged
frenck merged 2 commits into
hacs:masterfrom
ttiot:add-ttiot-curingchamber
Oct 21, 2026
Merged

frenck merged 2 commits into
hacs:masterfrom
ttiot:add-ttiot-curingchamber

Conversation

@ttiot

@ttiot ttiot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Checklist

  • I've read the publishing documentation.
  • I've added the HACS action to my repository.
  • (For integrations only) I've added the hassfest action to my repository.
  • The actions are passing without any disabled checks in my repository.
  • I've added a link to the action run on my repository below in the links section.
  • I've created a new release of the repository after the validation actions were run successfully.

Links

Link to current release: https://github.com/ttiot/curingChamber/releases/tag/v0.7.1
Link to successful HACS action (without the ignore key): https://github.com/ttiot/curingChamber/actions/runs/39562079019
Link to successful hassfest action (if integration): https://github.com/ttiot/curingChamber/actions/runs/39562078987

@hacs-bot hacs-bot Bot changed the title Add ttiot/curingChamber Adds new integration [ttiot/curingChamber] Oct 4, 2026
@hacs-bot

hacs-bot Bot commented Oct 4, 2026

Copy link
Copy Markdown

Thank you for submitting your repository to HACS (Home Assistant Community Store).

Your submission is in the review queue:
Your repository is waiting to be reviewed and included in HACS.

You can view the current queue here. Pull requests are processed in the order they were created, oldest first.

What to avoid during review:
To help reviewers work efficiently, don't do the following:

  • Comment on the pull request - The reviewer will contact you when they have feedback or questions.
  • Open a new pull request - This won't speed up the process and creates duplicate work.
  • Ask followers to comment on the pull request - This won't speed up the process and may delay your review.
  • Merge in the default branch - Only do this if a maintainer asks you to resolve a merge conflict.

If you need to make changes:
You can continue updating your repository while waiting for review. Changes to your repository will be reflected when the reviewer examines it. Only comment on the pull request if you need to withdraw your submission or have critical information for reviewers.

About draft pull requests:
Draft pull requests aren't included in the review queue. Your pull request may be marked as draft by a reviewer if issues need to be addressed. Once you've resolved all issues, mark it as ready for review to re-enter the queue.

What happens next:
Once a reviewer examines your submission, they'll either:

  • Approve and merge your pull request if everything meets the requirements
  • Request changes or ask questions if adjustments are needed

@ttiot
ttiot force-pushed the add-ttiot-curingchamber branch from a36517b to e786c73 Compare October 4, 2026 20:33

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ttiot, thanks for the submission! 👋

The weigh-in photo handling lets any logged-in user read files from the Home Assistant host. _photo_bytes in custom_components/curing_chamber/coordinator.py (lines 108-124) treats any string that points at an existing file as a path to read (os.path.isfile(photo), then open(photo, "rb")). That string comes straight from the record_weight and import_batch actions (services.py lines 144 and 121, photo and photo_data) and from the curing_chamber/weigh_in and curing_chamber/batch/import websocket commands (websocket.py lines 328-355 and 258-278). None of these are admin-only. A non-admin user can send photo: "/config/secrets.yaml" (or anything under .storage), the file is copied into the photo store, and curing_chamber/batch/export with include_photos: true hands it back base64 encoded.

The panel and the card already send data URLs, so the simplest fix is to drop the local path branch entirely. If you want to keep path support for the action, check it with hass.config.is_allowed_path(photo) first, and keep paths out of the websocket commands.

While you are at it: the README install section only describes adding a custom repository. Once this is in the default catalog, users can simply search for it in HACS, so lead with that.

Once that's addressed, push a new release and re-request review.

../Frenck

                       

Blogging my personal ramblings at frenck.dev
Or subscribe to my free bi-weekly newsletter: frenck.dev/newsletter

@ttiot

ttiot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review, and for the clear write-up.

Fixed in v0.7.1 (PR ttiot/curingChamber#13):

  • _photo_bytes in the coordinator now only decodes inline data (data URL or base64) and never touches the filesystem, so the weigh_in / batch/import websocket commands and import_batch cannot read a host file any more.
  • The record_weight action keeps accepting a local file path, but that is resolved in services.py only: the path must pass hass.config.is_allowed_path (allowlist_external_dirs), the file is read off the event loop and handed down as a data URL; anything else raises HomeAssistantError. Paths never reach the websocket layer.
  • Regression tests cover the allowed path, a refused path (secrets.yaml), and the websocket commands ignoring even an allowlisted path. services.yaml, README and CHANGELOG document the rule.
  • The README install section now leads with the HACS default catalog (search + My Home Assistant button); the custom-repository route is the fallback.

The PR links above are updated to the new release and the latest action runs. @frenck, could you take another look when you have a moment?

@ttiot
ttiot marked this pull request as ready for review October 21, 2026 07:32
@ttiot
ttiot requested a review from frenck October 21, 2026 07:36

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ttiot, thanks for the submission! 👋

Approving and merging now.

../Frenck

                       

Blogging my personal ramblings at frenck.dev
Or subscribe to my free bi-weekly newsletter: frenck.dev/newsletter

@frenck
frenck merged commit f89dfab into hacs:master Oct 21, 2026
13 checks passed
@hacs-bot

hacs-bot Bot commented Oct 21, 2026

Copy link
Copy Markdown

Congratulations! Your repository has been added to HACS 🎉

Your repository has been approved:
Your repository has been successfully merged into the HACS default repository list.
It might take up to 8 hours before your repository appears in HACS for users.

Resources:

Thank you for contributing to the Home Assistant community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants