Repository navigation
feat: make podManagementPolicy configurable - #13
Open
gerardosabetta wants to merge 1 commit into
Open
gerardosabetta wants to merge 1 commit into
gerardosabetta wants to merge 1 commit into
Conversation
Expose the StatefulSet podManagementPolicy as a chart value restricted to Parallel or OrderedReady. The default stays Parallel: the field is immutable on an existing StatefulSet, and OrderedReady cannot bootstrap a fresh multi-node cluster with the default /health readiness probe. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Closes #5
What
Adds a
podManagementPolicyvalue (ParallelorOrderedReady) and uses it in the StatefulSet instead of the hardcodedParallel.Why the default stays
ParallelThe issue proposes switching the default to
OrderedReady. This PR makes it opt-in instead:podManagementPolicyis immutable on an existing StatefulSet, so a new default would makehelm upgradefail for every current install.OrderedReady, pod N only starts after pod N-1 is Ready. A single Typesense node has no Raft quorum, so with the default/healthreadiness probe a fresh multi-node install is expected to stall on pod 0. This is reasoned from the chart, not reproduced in a cluster.Users who want ordered scaling can set
podManagementPolicy=OrderedReadytogether withreadinessProbe.type=tcpSocket. The value description documents this and the immutability caveat.Changes
templates/statefulset.yaml: read the policy from valuesvalues.yaml,values.schema.json: new value with an enum constraintREADME.md,values.md: documented (edited by hand in the helm-docs format)tests/statefulset_test.yaml: default, override and invalid-value casesTesting
helm lint .passeshelm unittest .: 97 tests pass across 9 suites (run with thehelmunittest/helm-unittest:4.3.0-1.2.1image)helm templaterendersParallelby default andOrderedReadywhen set; an unknown value is rejected by the schemaNo chart version bump or changelog entry is included.
🤖 Generated with Claude Code