Skip to content

feat: make --reset-peers-on-error configurable via values - #12

Open
gerardosabetta wants to merge 1 commit into
hackthebox:mainfrom
gerardosabetta:claude/typesense-helm-issue-3-d2da1c
Open

gerardosabetta wants to merge 1 commit into
hackthebox:mainfrom
gerardosabetta:claude/typesense-helm-issue-3-d2da1c

Conversation

@gerardosabetta

Copy link
Copy Markdown

Closes #3

What

Adds typesense.resetPeersOnError (boolean, default true). When false, the StatefulSet no longer passes --reset-peers-on-error to Typesense. The default keeps the rendered command identical to today.

Changes

  • templates/statefulset.yaml: flag wrapped in a conditional
  • values.yaml, values.schema.json: new boolean key
  • values.md, README.md: new row in the values table
  • tests/statefulset_test.yaml: cases for default and disabled

Verification

  • helm lint . passes
  • helm template renders the flag by default and omits it with --set typesense.resetPeersOnError=false
  • The schema rejects a non-boolean value
  • Not run locally: helm unittest (plugin not installed). Relying on CI for the suite.

Notes

values.schema.json, values.md and README.md were edited by hand rather than regenerated with mise run schema / mise run docs; a regeneration may produce small formatting differences. Chart version is not bumped.

🤖 Generated with Claude Code

Add typesense.resetPeersOnError (default true, preserving current behaviour) so operators can drop the flag and avoid extra Raft membership churn during catch-up.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@gerardosabetta
gerardosabetta requested a review from a team as a code owner November 10, 2026 01:01
@gerardosabetta

Copy link
Copy Markdown
Author

Slide 1: Peer resets on error are now a choice

Slide 2: Every install got the flag, with no way to turn it off

Slide 3: One conditional around one argument

Slide 4: A new boolean under typesense

Slide 5: What was checked locally

Slide 6: What the reviewer should know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make --reset-peers-on-error configurable via values

1 participant