Repository navigation
Warn organizers when event dates change after waivers went out - #156
Merged
Merged
Conversation
DocuSeal waiver templates have the event dates printed on them at clone time, and each sent waiver snapshots its template. Moving an event's dates afterwards silently leaves every waiver showing the old dates. Saving still works, but the event is now flagged and every admin page for it shows a banner telling organizers to reach out to the Attend team. Global admins clear it once the templates are fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a waiver template is cloned for an event,
Docuseal::DefaultTemplateSetupprints the event dates onto it, and each sent DocuSeal submission keeps a snapshot of its template. If the event's dates move later, every waiver already sent (and every new one) still shows the old dates. Nothing in Attend tells anyone.Change
waiver_dates_stale_sinceset.AuditLog.Testing
spec/requests/api/v1/webhooks_spec.rb:247, which depends on whether a DocuSeal webhook secret is configured locally. It passes or fails based on the localmaster.key, not this change.After deploy
Events whose dates moved before this shipped won't be flagged automatically. Set the flag by hand where needed.