Repository navigation
release: v0.3.3 — Config.Dir child process CWD - #6
Merged
Merged
Conversation
Default = DataDir. Prevents daemon from holding parent's CWD which may be deleted or unmounted after start.
- DataDir resolved to absolute path in applyDefaults (before Dir default) - Dir defaults to absolute DataDir — prevents .gode/.gode doubling with relative DataDir on Windows - CHANGELOG, README, ROADMAP updated for v0.3.3 - Removed stale ADR references from public docs
Config is normalized once at construction (New/NewWithDeps). Methods only read d.cfg — concurrent calls are safe. Removes 4x d.cfg.applyDefaults() from Start/EnsureRunning/Stop/Restart. Fixes race detected by -race on TestStart_ConcurrentStartsSerialized. Last stale ADR reference removed from ROADMAP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config.Dir sets the working directory for the spawned daemon process. Default = DataDir. Prevents daemon from holding the parent's CWD which may be deleted or unmounted after start.