You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Read plugin manifests in graphwire through the strict manifest reader #168
Current state:pluginkit/graphwire reads each plugin.json on its own, with encoding/json v1, into its own id, backend and graphql fields. So it matches keys in any case and lets a key repeat, while wire rejects both since #167. A manifest holding "GraphQL": true keeps that key as the application's own data in wire, but graphwire reads it as graphql and wires the plugin's graph. One file means two things.
Proposal:
wire.Manifest gains a typed GraphQL field for the documented graphql key. Its spelling is then checked like every other key, and it leaves Extra, a breaking change.
graphwire requires github.com/gopherium/framework/pluginkit and reads each manifest through wire.Read, so both generators read one file the same way.
graphwire rejects every manifest wire rejects, with the same error.
Both modules list the change under Unreleased. No release.
Trigger: Every pluginkit generator should read one plugin.json the same way. After #167, wire reads each key exactly as written, the way Go's JSON v2 does by default.
Activity