expr: check NewAttributeDecoder error before use in CtTimeout - #368
Open
vulragrag-star wants to merge 1 commit into
Open
vulragrag-star wants to merge 1 commit into
vulragrag-star wants to merge 1 commit into
Conversation
CtTimeout.unmarshal set decoder.ByteOrder before checking the error from NewAttributeDecoder. On a truncated nested NFTA_CT_TIMEOUT_DATA payload the decoder is nil, so that assignment panicked instead of returning an error. Move the error check above the dereference and add a regression test. Fixes google#367 Signed-off-by: Jason Wang <vulragrag@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I signed the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CtTimeout.unmarshalsetdecoder.ByteOrderbefore checking the error fromnetlink.NewAttributeDecoder. On a truncated nestedNFTA_CT_TIMEOUT_DATApayload the decoder is nil, so that assignment panicked instead of returning an error.Every other similar call site in the repo checks
errfirst; this one was the only inversion.Fixes #367
Test plan
expr/ct.goondecoder.ByteOrder.Partial fix for the check-after-use called out in #367 (other short-attribute sites from that issue left for follow-up).