Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94
Summary
{#opener at end-of-file as an empty comment, matching Jinja2{#followed by a space) as errorsCompatibility detail
Jinja2's behavior is narrower than accepting every unterminated comment: a bare
{#at EOF renders as an empty comment, while{#followed by content still raisesMissing end of comment tag. This change preserves that distinction.Validation
SyntaxTest.SimpleCasespassed against Minja when the change was preparedUSE_JINJA2=1against Jinja2 3.1.6git diff --checkpasses on the current branchmain(0 commits behind)The main CI and security-scan workflows are currently
action_requiredand need a Google maintainer to approve the fork workflow run.