Repository navigation
Publish release artifacts and build the container image in CI - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was missing
Trying davcloud required a toolchain: no tags, no releases, no image, and the
README started at
git cloneplusgo build. TheDockerfilethat alreadyexisted was never built by CI and predated the versioned
go.sum: its buildstage ran
go mod tidyand stamped no version at all, so the image could noteven report what it was.
What this changes
Dockerfile: modules now come from the versionedgo.sum(go mod downloadovergo.mod+go.sum), and version, commit and date arrive asbuild args, so the binary inside the image reports the tag it was built from.
OCI labels added, including the license the README declares.
release.yml(new): av*tag buildslinux/amd64andlinux/arm64static binaries with
CGO_ENABLED=0, writes a.sha256per binary,publishes the GitHub release with generated notes, and pushes a multi-arch
image to
ghcr.io/<owner>/davcloudtagged with the version andlatest.ci.yml: newimagejob that builds the image on every push and pullrequest (single arch, nothing published) and runs
-versioninside it, sothe
Dockerfilecannot rot unnoticed again.(checksum included) and the
docker runpath;deploy/README.mdoffers thereleased binary as the way to skip the toolchain;
PLAN.mdrecords thehardening now in production, adds the distribution phase and stops claiming
"no containers" without qualification.
How it was checked
go vet ./...,gofmt -l .,go mod tidy(no diff) andgo test ./... -race -shuffle=on -count=1: all green.go mod downloadlayer was reproduced outside Docker with onlygo.modand
go.sumin an empty directory (exit 0): that is the layer that used todepend on
go.sumexisting.flags and a local port and directories (
-addr :5232 -data-dir /data -ui-dir /app/ui -dev-user alice):PROPFIND /caldav/-> 207,/carddav/->207. The example is not aspirational.
actionlint(v1.7.12, built from source) on both workflows: no findings.from the GitHub API (
setup-qemu-action@v4,setup-buildx-action@v4,login-action@v4).Not covered here
release workflow. The
v0.2.0tag and the checks after it (assets, anonymouspull) come next, in the same issue.
volume (
0.2.0-dev, commitac395f0, deployed 2026-10-18).Closes #43