Repository navigation
Web UI: write vCard 3.0 and add vitest for the vCard/ICS helpers - #30
Merged
Merged
Conversation
- buildVCard wrote VERSION:4.0 (plus KIND, a 4.0 property) while the stored cards in the wild are 3.0; it now writes 3.0 without KIND. - vitest with 10 tests over vcard.ts and ics.ts: escape/unescape round trip (backslash, semicolon, comma, newlines), UID generation, the 3.0 shape, recurrence expansion inside a range and non-recurring filtering, and the empty result for unparseable input. - Writing the tests caught a real UI bug: parseVCard lost newlines when unescaping (\n became a bare n), so notes with line breaks rendered wrong; it now unescapes per RFC 6350 (newline first, then the rest). - CI web job runs npm test before the build. Closes #23. Closes #24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23. Closes #24.
buildVCardwrote VERSION:4.0 (plus KIND, a 4.0 property) while the stored cards in the wild are 3.0; it now writes 3.0 without KIND.vcard.tsandics.ts: escape/unescape round trip, UID generation, the 3.0 shape, recurrence expansion and filtering, empty result on unparseable input.parseVCardlost newlines when unescaping (\\nbecame a baren); it now unescapes per RFC 6350.npm testbefore the build.