Repository navigation
fix(preview): a line end stays a line break (#57) - #58
Merged
Merged
Conversation
Issue #57: three lines typed "1.Drink water", "2.Eat", "3.Sleep." came out in the preview as ONE line, "1.Drink water 2.Eat 3.Sleep.". Measured on the JVM: "1. Eat" with a space after the dot IS a list in the preview. Everything else followed CommonMark, as 2.0.9 did (softLineBreak: false): a single line end inside a paragraph became a space. So these all came out on one line: "1.Eat" with no space (not a list), a full-width dot or ideographic space typed by an Asian keyboard, a no-break space, a list starting at "2." under a line of text, and any run of plain text lines. Now every line end is a line break, as in the editor (D-045): a note is written on a phone, line by line, and Obsidian, Joplin and GitHub's comments keep line ends the same way. List recognition does not change. A hard break (two spaces or a backslash) still gives ONE break: the line end it sits on adds nothing after it. The legal pages go through the same reader. The five terms.md quoted the whisper.cpp MIT notice wrapped at about 100 columns (and, in English and French, the paragraph introducing it): each paragraph is now on one line. Only spacing changes, checked by script; the three copyright lines stay lines, as in the licence, and now show one under the other. PagesLegalesTest keeps every paragraph of a legal page on one line; negative control: the old English terms.md makes it fail. Changelogs 5071-5073 get one line in the five languages (longest: German, 491 characters). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed 3.4.0 APKs checked (TOUT OK), update 3.3.0 -> 3.4.0 tried on the S9 with the issue #57 note, F-Droid state of 10 November, site draft PR, and the steps of release day. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57 in 3.4.0, which is merged but not yet published.
What was wrong
In the preview, a single line end inside a paragraph became a space. That is CommonMark, and what 2.0.9 did (
softLineBreak: false). Measured on the JVM:1. Eat⏎2. Drink(space after the dot)1.Drink water⏎2.Eat(the issue's example)1.Drink water 2.Eat, one line1.Eat(full-width dot),1. Eat(ideographic space), no-break spaceToday:⏎2. Eat⏎3. DrinkChange (D-045,
docs/15-VERSION-3.4.md)1.Eatis still text, now on its own line.\) still gives one break. A line holding only\keeps its empty line.terms.md, the MIT notice of whisper.cpp was wrapped at about 100 columns, and so was the paragraph introducing it in English and French. Each paragraph is now on one line. Only spacing changes, checked by script. The three copyright lines stay separate lines, as in the licence.privacy.mdhad no wrapped paragraph. "About" shows only string resources, so it needed no change.PagesLegalesTestnow checks that no paragraph of a legal page holds a line end, except the copyright lines. Negative control: the old Englishterms.mdmakes it fail.Checks
assembleDebug testDebugUnitTest lintDebug detekt ktlintCheck, green.\, a break inside a style or a link, plus the legal-page guard.Reply to #57: post AFTER the 3.4.0 release
🤖 Generated with Claude Code