fix(fa): Persian typos, dead links, a dropped pull quote and bidi punctuation - #3752
Open
Parhamfakhar1 wants to merge 3 commits into
Open
Parhamfakhar1 wants to merge 3 commits into
Parhamfakhar1 wants to merge 3 commits into
Conversation
…st marker The Persian articles carried a handful of defects that are visible on the published site (https://opensource.guide/fa/...) and are not produced by the translation itself: * starting-a-project.md: the heading and body used "منافات", which is not a Persian word. English reads "Avoiding name conflicts" / "trademark conflicts", so it is corrected to "تعارض" (3 places). The in-page anchor in legal.md is updated in the same commit so the link keeps resolving. * maintaining-balance-for-open-source-maintainers.md: one list item started with an extra "* ", which kramdown renders as an empty nested ul/li on the live page. * 4 lines ended with a duplicated full stop, one of them inside the description front matter of finding-users.md, which is emitted as the page's meta description. * metrics.md: a sentence ran into the next one without a space after the period. * Dead / stale links that only exist in the Persian copy, now set to the URLs the English article already uses: citizencodeofconduct.org (domain no longer resolves) -> Wayback snapshot, runcommand.io (now redirects to an unrelated squatted domain) -> Wayback snapshot of danielbachhuber.com, opensource.org/osd-annotated -> /definition-annotated/, eclipse.org/org/ -> www.eclipse.org/org/. * 2 duplicated words ("در در ارتباط", "این این مورد") and "املائی" (Arabic ya) -> "املایی", plus a missing half-space in "شاخهشاخه". * Removed double spaces between Persian words and zero-width joiners left stranded at the start of a word (they render as a phantom gap). Only description/typography/link-URL fields were touched; no translated prose was rewritten. node test/prose reports no issues.
The word for 'maintainer' is نگهدارنده; the article uses نگاهدارنده (with گ where ه belongs), which is not a Persian word. EN source line: 'Your job as a maintainer ...' -> fa line 197.
The English article introduces the quote and then shows it as a styled pull
quote with the source credit:
<aside markdown="1" class="pquote">
<img src="/assets/images/how-to-contribute/johnfkennedy.jpg" ...
— [_John F. Kennedy Library_](https://www.jfklibrary.org/...)
The Persian copy kept the lead-in sentence (and the quote inside it) but the
whole aside was dropped, so the Persian page has 7 pull quotes where every
other language has 8, and the link to the source of the quote is lost.
Also fixes the punctuation of that lead-in line: "که گفت:«..." (no space after
the colon) and an en-dash glued to the preceding word, which breaks bidi
ordering when rendered right-to-left.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
This cleans up defects in the Persian articles that are visible on the published
pages (https://opensource.guide/fa/...). Nothing here rewrites translation prose:
the changes are spelling, punctuation, markup, and link targets.
Content bugs
_articles/fa/starting-a-project.md— the heading "از نامگذاریهای دارای منافاتخودداری کنید" and two body uses contain "منافات", which is no Persian word. The
English reads "Avoiding name conflicts" / "trademark conflicts", so this uses
"تعارض". The matching in-page anchor in
_articles/fa/legal.mdis updated in thesame commit, because the anchor is derived from that heading's text.
_articles/fa/building-community.md— "نگاهدارنده" → "نگهدارنده" (maintainer)._articles/fa/maintaining-balance-for-open-source-maintainers.md— a list itembegan with an extra
*, so kramdown emitted an empty nested<ul><li>(can beseen in the live page source at "به جامعه تکیه کنید").
_articles/fa/how-to-contribute.md— the Kennedy<aside class="pquote">block(avatar + styled quote + link to the source) was dropped, leaving 7 pull quotes
where every other language has 8. Restored; the quote text reuses the wording the
Persian lead-in already uses, and the credit/URL is copied from English.
getting-paid.md), "این این مورد"(
how-to-contribute.md).Typography
description:offinding-users.md, which is emitted as the page's meta description.metrics.md), one en-dash glued to thepreceding word inside RTL text (breaks bidi ordering), one Arabic-ya spelling
("املائی" → "املایی"), one missing half-space ("شاخه شاخه" → "شاخهشاخه").
of a word (they render as a phantom gap) removed across the fa articles.
Links (only the URL changed, per docs/translations.md)
These targets exist only in the Persian copy; each now matches the URL the English
article already uses:
http://citizencodeofconduct.org/curl→ 000)https://runcommand.io/2016-06-26/my-condolences-…danielbachhuber.comhttps://opensource.org/osd-annotatedhttps://opensource.org/definition-annotated/https://eclipse.org/org/https://www.eclipse.org/org/node test/prose→ no issues. In-page anchors across_articles/fa/*.mdallresolve (checked against the ids the live build generates).
Two follow-ups I did not include, to keep this reviewable: 50 hyperlinks present in
the English articles have no equivalent in the Persian ones (
legal.mdalone accountsfor 17, mostly because several English paragraphs were merged together in translation),
and
accessibility-best-practices-for-your-project.mdhas no Persian version yet —#3753 adds it as its own PR. The SAST list-marker fix is a separate, English-only PR: #3754.