Skip to content

fix: add explicit destructiveHint false to non-destructive write tools #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larik15 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add explicit destructiveHint false to non-destructive write tools #3293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/add_comment_to_pending_review.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Add review comment to the requester's latest pending pull request review"
Expand Down
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/add_issue_comment.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Add comment to issue or pull request"
Expand Down
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/add_reply_to_pull_request_comment.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Add reply to pull request comment"
Expand Down
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/create_branch.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Create branch"
Expand Down
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/create_gist.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Create Gist"
Expand Down
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/create_pull_request.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
}
},
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Open new pull request"
Expand Down
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/create_repository.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Create repository"
Expand Down
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/create_repository_ruleset.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Create repository ruleset"
Expand Down
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/fork_repository.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Fork repository"
Expand Down
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/request_copilot_review.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Request Copilot review"
Expand Down
1 change: 1 addition & 0 deletions pkg/github/__toolsnaps__/star_repository.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"annotations": {
"destructiveHint": false,
"idempotentHint": false,
"readOnlyHint": false,
"title": "Star repository"
Expand Down
5 changes: 3 additions & 2 deletions pkg/github/copilot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,8 +888,9 @@ func RequestCopilotReview(t translations.TranslationHelperFunc) inventory.Server
Description: t("TOOL_REQUEST_COPILOT_REVIEW_DESCRIPTION", "Request a GitHub Copilot code review for a pull request. Use this for automated feedback on pull requests, usually before requesting a human reviewer."),
Icons: octicons.Icons("copilot"),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_REQUEST_COPILOT_REVIEW_USER_TITLE", "Request Copilot review"),
ReadOnlyHint: false,
Title: t("TOOL_REQUEST_COPILOT_REVIEW_USER_TITLE", "Request Copilot review"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: schema,
},
Expand Down
5 changes: 3 additions & 2 deletions pkg/github/gists.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,9 @@ func CreateGist(t translations.TranslationHelperFunc) inventory.ServerTool {
Name: "create_gist",
Description: t("TOOL_CREATE_GIST_DESCRIPTION", "Create a new gist"),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_CREATE_GIST", "Create Gist"),
ReadOnlyHint: false,
Title: t("TOOL_CREATE_GIST", "Create Gist"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: &jsonschema.Schema{
Type: "object",
Expand Down
5 changes: 3 additions & 2 deletions pkg/github/issues.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1369,8 +1369,9 @@ func AddIssueComment(t translations.TranslationHelperFunc) inventory.ServerTool
Name: "add_issue_comment",
Description: t("TOOL_ADD_ISSUE_COMMENT_DESCRIPTION", "Add a comment and/or reaction to a specific issue or issue comment in a GitHub repository. Use this tool with pull requests as well (in this case pass pull request number as issue_number), but only if user is not asking specifically to add or react to review comments. At least one of body or reaction is required."),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_ADD_ISSUE_COMMENT_USER_TITLE", "Add comment to issue or pull request"),
ReadOnlyHint: false,
Title: t("TOOL_ADD_ISSUE_COMMENT_USER_TITLE", "Add comment to issue or pull request"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: &jsonschema.Schema{
Type: "object",
Expand Down
15 changes: 9 additions & 6 deletions pkg/github/pullrequests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,8 +654,9 @@ func CreatePullRequest(t translations.TranslationHelperFunc) inventory.ServerToo
Name: "create_pull_request",
Description: t("TOOL_CREATE_PULL_REQUEST_DESCRIPTION", "Create a new pull request in a GitHub repository."),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_CREATE_PULL_REQUEST_USER_TITLE", "Open new pull request"),
ReadOnlyHint: false,
Title: t("TOOL_CREATE_PULL_REQUEST_USER_TITLE", "Open new pull request"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
Meta: mcp.Meta{
"ui": map[string]any{
Expand Down Expand Up @@ -1214,8 +1215,9 @@ func AddReplyToPullRequestComment(t translations.TranslationHelperFunc) inventor
Name: "add_reply_to_pull_request_comment",
Description: t("TOOL_ADD_REPLY_TO_PULL_REQUEST_COMMENT_DESCRIPTION", "Add a reply and/or reaction to an existing pull request comment. This can create a new comment linked as a reply to the specified comment, add an emoji reaction to the specified comment, or do both. At least one of body or reaction is required."),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_ADD_REPLY_TO_PULL_REQUEST_COMMENT_USER_TITLE", "Add reply to pull request comment"),
ReadOnlyHint: false,
Title: t("TOOL_ADD_REPLY_TO_PULL_REQUEST_COMMENT_USER_TITLE", "Add reply to pull request comment"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: schema,
},
Expand Down Expand Up @@ -2393,8 +2395,9 @@ func AddCommentToPendingReview(t translations.TranslationHelperFunc) inventory.S
Name: "add_comment_to_pending_review",
Description: t("TOOL_ADD_COMMENT_TO_PENDING_REVIEW_DESCRIPTION", "Add review comment to the requester's latest pending pull request review. A pending review needs to already exist to call this (check with the user if not sure)."),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_ADD_COMMENT_TO_PENDING_REVIEW_USER_TITLE", "Add review comment to the requester's latest pending pull request review"),
ReadOnlyHint: false,
Title: t("TOOL_ADD_COMMENT_TO_PENDING_REVIEW_USER_TITLE", "Add review comment to the requester's latest pending pull request review"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: schema,
},
Expand Down
20 changes: 12 additions & 8 deletions pkg/github/repositories.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,8 +644,9 @@ func CreateRepository(t translations.TranslationHelperFunc) inventory.ServerTool
Name: "create_repository",
Description: t("TOOL_CREATE_REPOSITORY_DESCRIPTION", "Create a new GitHub repository in your account or specified organization"),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_CREATE_REPOSITORY_USER_TITLE", "Create repository"),
ReadOnlyHint: false,
Title: t("TOOL_CREATE_REPOSITORY_USER_TITLE", "Create repository"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: &jsonschema.Schema{
Type: "object",
Expand Down Expand Up @@ -1210,8 +1211,9 @@ func ForkRepository(t translations.TranslationHelperFunc) inventory.ServerTool {
Description: t("TOOL_FORK_REPOSITORY_DESCRIPTION", "Fork a GitHub repository to your account or specified organization"),
Icons: octicons.Icons("repo-forked"),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_FORK_REPOSITORY_USER_TITLE", "Fork repository"),
ReadOnlyHint: false,
Title: t("TOOL_FORK_REPOSITORY_USER_TITLE", "Fork repository"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: &jsonschema.Schema{
Type: "object",
Expand Down Expand Up @@ -1503,8 +1505,9 @@ func CreateBranch(t translations.TranslationHelperFunc) inventory.ServerTool {
Name: "create_branch",
Description: t("TOOL_CREATE_BRANCH_DESCRIPTION", "Create a new branch in a GitHub repository"),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_CREATE_BRANCH_USER_TITLE", "Create branch"),
ReadOnlyHint: false,
Title: t("TOOL_CREATE_BRANCH_USER_TITLE", "Create branch"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: &jsonschema.Schema{
Type: "object",
Expand Down Expand Up @@ -2505,8 +2508,9 @@ func StarRepository(t translations.TranslationHelperFunc) inventory.ServerTool {
Description: t("TOOL_STAR_REPOSITORY_DESCRIPTION", "Star a GitHub repository"),
Icons: octicons.Icons("star-fill"),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_STAR_REPOSITORY_USER_TITLE", "Star repository"),
ReadOnlyHint: false,
Title: t("TOOL_STAR_REPOSITORY_USER_TITLE", "Star repository"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: &jsonschema.Schema{
Type: "object",
Expand Down
5 changes: 3 additions & 2 deletions pkg/github/rulesets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,8 +656,9 @@ func CreateRepositoryRuleset(t translations.TranslationHelperFunc) inventory.Ser
Name: "create_repository_ruleset",
Description: t("TOOL_CREATE_REPOSITORY_RULESET_DESCRIPTION", "Create a new ruleset at the repository, organization, or enterprise level"),
Annotations: &mcp.ToolAnnotations{
Title: t("TOOL_CREATE_REPOSITORY_RULESET_USER_TITLE", "Create repository ruleset"),
ReadOnlyHint: false,
Title: t("TOOL_CREATE_REPOSITORY_RULESET_USER_TITLE", "Create repository ruleset"),
ReadOnlyHint: false,
DestructiveHint: jsonschema.Ptr(false),
},
InputSchema: &jsonschema.Schema{
Type: "object",
Expand Down