Repository navigation
Conversation
sentry-dotnet preloads the crash handler so that it is installed before the .NET runtime's `SIGSEGV` handler, which turns null dereferences in Native AOT-compiled managed code into `NullReferenceException`. With the handler already installed (#2268), `sentry__crash_handler_init()` ignored its callback (#2220), so sentry-crash never called `dump_crash_queue()`.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fd541ca. Configure here.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v1 #2329 +/- ##
==========================================
+ Coverage 75.72% 75.82% +0.09%
==========================================
Files 105 105
Lines 30936 30938 +2
Branches 5775 5775
==========================================
+ Hits 23426 23458 +32
+ Misses 6075 6042 -33
- Partials 1435 1438 +3 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes a small shortcoming noticed while working on Native backend support in Sentry.NET.
Long story short, sentry-dotnet preloads the crash handler so that it is installed before the .NET runtime's
SIGSEGVhandler, which turns null dereferences in Native AOT-compiled managed code intoNullReferenceException.With the handler already installed (#2268),
sentry__crash_handler_init()ignored its callback (#2220), so sentry-crash never calleddump_crash_queue().The fix sets the callback when
sentry__crash_handler_init()adopts the preloaded handler, as it already does for the IPC and the handler strategy, and clears it when the preloaded handler is deactivated.#skip-changelog (internal)