Skip to content

remove deprecated gitlab links - #15

Merged
Derekf5 merged 1 commit into
mainfrom
jay/86-gitlab
Sep 22, 2026
Merged

Derekf5 merged 1 commit into
mainfrom
jay/86-gitlab

Conversation

@jay-418

@jay-418 jay-418 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

summary

Removes the deprecated lantern-binaries-mirror GitLab links from the profile downloads table.

GitHub and S3 stable links remain for all three platforms.

deploy

Summary by CodeRabbit

  • Documentation
    • Updated stable download information across supported languages.
    • Windows, Android, and macOS stable installers now link through GitHub Releases and production hosting.
    • Removed GitLab mirror links from the published download tables and templates.
    • Other download options, including beta links, remain unchanged.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0802d0a4-6f77-45e4-b527-afc9337ccee9

📥 Commits

Reviewing files that changed from the base of the PR and between 709a3e9 and 616ad99.

📒 Files selected for processing (8)
  • profile/README.ar.md
  • profile/README.fa.md
  • profile/README.md
  • profile/README.my.md
  • profile/README.ru.md
  • profile/README.zh.md
  • updater/templates/README.md.tmpl
  • updater/translations/common.json
💤 Files with no reviewable changes (8)
  • profile/README.fa.md
  • updater/translations/common.json
  • profile/README.ru.md
  • profile/README.my.md
  • profile/README.zh.md
  • updater/templates/README.md.tmpl
  • profile/README.md
  • profile/README.ar.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change removes GitLab mirror links for stable Windows, Android, and macOS installers from updater sources and localized profile READMEs. GitHub Releases and S3 links remain.

Changes

Stable download links

Layer / File(s) Summary
Updater download sources
updater/templates/README.md.tmpl, updater/translations/common.json
The stable Windows, Android, and macOS entries no longer define GitLab mirror links. GitHub, S3, beta, and Play Store links remain where present.
Localized profile download tables
profile/README*.md
The Arabic, Farsi, English, Malay, Russian, and Chinese stable-download rows no longer list GitLab mirror links. GitHub Releases and S3 links remain.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 616ad

The PR removes deprecated GitLab mirror links while retaining GitHub and S3 downloads; no merge-blocking risk is evidenced.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing deprecated GitLab download links.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@jay-418
jay-418 requested a lite review from Copilot September 22, 2026 16:07
@jay-418

jay-418 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

cc: @Derekf5

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Removes deprecated GitLab download links while retaining GitHub and S3 links.

Changes:

  • Removed GitLab link definitions and template rows.
  • Regenerated localized profile README files.
File Description
updater/​translations/​common.json Removed deprecated link definitions.
updater/​templates/​README.md.tmpl Removed GitLab download rows.
profile/​README.zh.md Regenerated Chinese profile.
profile/​README.ru.md Regenerated Russian profile.
profile/​README.my.md Regenerated Burmese profile.
profile/​README.md Regenerated English profile.
profile/​README.fa.md Regenerated Farsi profile.
profile/​README.ar.md Regenerated Arabic profile.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Derekf5
Derekf5 merged commit c3f64f1 into main Sep 22, 2026
2 checks passed
@Derekf5
Derekf5 deleted the jay/86-gitlab branch September 22, 2026 16:19
@Derekf5

Derekf5 commented Sep 22, 2026

Copy link
Copy Markdown

Took over verification + deploy from @jay-418.

Verified before merge

  • go test ./... passes; go run ./updater on the branch reproduces the committed profile/ byte-for-byte (clean git status after regen).
  • No remaining gitlab / lantern-binaries-mirror references anywhere in this repo.

Deploy

  • Squash-merged as c3f64f1.
  • update workflow run succeeded; updater was a no-op (nothing to commit) and the dispatch to getlantern/lantern fired.
  • Downstream mirror.yml run succeeded and pushed getlantern/lantern@8c71dfb — all six README*.md there are now GitLab-free.
  • Public org profile confirmed: stable column shows only GitHub + S3 links for Windows/Android/macOS, zero "gitlab" matches on the page.

Follow-up (out of scope here): getlantern/lantern-internal/scripts/copyInstallersToMirrors.bash still pushes installers to git@gitlab.com:getlantern/lantern-binaries-mirror.git. If the mirror is fully deprecated, that upload can be dropped too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants