Repository navigation
test(client): cover autocomplete without a segment - #8
Merged
MobileMage merged 1 commit intoOct 4, 2026
Merged
Conversation
Add empty and non-empty suggestions without a segment to the unreadable response cases (T-4). Both must raise unexpected_response, as issue gatepost-dev#5 asks. Signed-off-by: Lui Lui <40736418+lui01212@users.noreply.github.com>
Contributor
|
Merged as 1773243. Both cases sit where a reader looks for them, in the existing provider, and the second one (a missing segment with a suggestion present) is the case that a quick fix would miss. That is three merged changes across three repos now. The open |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing-segment cases requested in #5, with both empty and non-empty suggestions.
Both responses raise unexpected_response on the existing implementation. This change adds tests
only, so it needs no change file.
composer check, unit tests on PHP 8.1 and 8.5, contract tests against the mock server on both
versions, sign-off and squash-message checks pass on the fork.
CI: https://github.com/lui01212/php/actions/runs/37173552823
Closes #5
Codex helped write the two regression cases and review the diff.
Signed-off-by: Lui Lui 40736418+lui01212@users.noreply.github.com