Repository navigation
chore(repo): move to spec 0.3.0 - #7
Merged
Merged
Conversation
The spec now holds the contract of the field and its message catalogue, which the next packages build on. The grammar and the client contract stay as they were, so every function of the package gives the same results and the package only reports the new spec version. The agents file names the new interface file, so an agent that needs a field symbol finds where the spec lists it. Signed-off-by: MobileMage <aidelojejoshua@gmail.com>
Postcode::SPEC_VERSION takes a new value with each spec version by design, so a change of that value is not a break of the public API. Since the first release tag, the BC check compared the constant with the tag and failed the move to spec 0.3.0. The script now drops that one finding, prints every other finding with its own count, and exits non-zero for any other break or any other failure of the tool. A test feeds the filter the finding alone and with a second break. The developing guide names the exception. Signed-off-by: MobileMage <aidelojejoshua@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package now implements spec 0.3.0. That version adds the postcode
field and its messages, and the WordPress and WooCommerce floors in the
PHP standard. It leaves the grammar and the client contract as they
were, so every function gives the same results as before.
The docs site checks that every SDK it documents implements one spec
version, and the TypeScript packages are on 0.3.0 already.
Signed-off-by: MobileMage aidelojejoshua@gmail.com