Repository navigation
fix(translator): reject non-variation types in _from_vrs - #668
Merged
Merged
Conversation
Validate VRS dict input against the models.Variation union instead of looking up any attribute of the models module by name. Types that are not VRS variations (e.g. SequenceLocation, or unrelated module attributes like Field) now raise a pydantic ValidationError listing the accepted types, rather than building a non-variation object or returning None.
theferrit32
marked this pull request as ready for review
October 19, 2026 17:42
korikuzma
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#656 fixed the
TypeErrorin_from_vrs, but itsgetattr(models, var["type"])lookup accepts any attribute of themodelsmodule. Inputs like{"type": "SequenceLocation", ...}or{"type": "Field"}return non-variation objects.This narrows the accepted types to VRS variations by validating against the existing
models.Variationunion (tagged bytype, mirroring the VRSVariationschema). Other types now raise a pydanticValidationErrorlisting the accepted types.