Repository navigation
Conversation
This was referenced Nov 7, 2026
hertzcodes
self-requested a review
November 7, 2026 08:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements opt-in consumer auto-ack for #77. Workers request it with
SubscribeInit.auto_ack;delivery.subscriptions.allowAutoAckdefaults to false and rejects such streams withPermissionDeniedbefore creating sessions. Accepting brokers confirm the mode in initial metadata.After a successful stream send, the broker queues that recipient's completion through the existing batched ACK ledger. Failed sends remain pending, persistence failures retry, and other subscriptions retain their delivery obligations. Both manual ACK and NACK requests are ignored on auto-ack streams, including while sending is blocked. Manual streams keep their current behavior.
Includes YAML/environment configuration, API and delivery documentation, failed-send and persistence-retry tests, policy tests, and mixed manual/auto-ack delivery tests for Pebble and Bolt.
Validation:
go test ./...passes on Linux, including Raft cluster tests.-raceon Windows.Depends on futureq-io/protocol#2. Until that change is merged and released,
go.modexplicitly replaces the protocol module with the immutable commit inAmHonored/protocol. Switch to the upstream release and remove the replacement after the protocol PR lands.SDK implementation: futureq-io/sdk#3.