Skip to content

fix: handle commander.help exit code for help <cmd> invocation #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shouze merged 1 commit into from
Mar 2, 2026
Merged

fix: handle commander.help exit code for help <cmd> invocation #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions github-issue-ops.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,19 @@ function collect(value: string, previous: string[]): string[] {
}

function exitOnError(err: Error): never {
// Commander throws CommanderError on --help / --version — ignore those
if ((err as { code?: string }).code === "commander.helpDisplayed") process.exit(0);
if ((err as { code?: string }).code === "commander.version") process.exit(0);
// Commander throws CommanderError on --help / --version — ignore those.
// Possible codes: "commander.helpDisplayed" (--help flag) or "commander.help"
// (built-in `help <cmd>` invocation). Both have exitCode 0.
const code = (err as { code?: string; exitCode?: number }).code;
const exitCode = (err as { exitCode?: number }).exitCode;
if (
code === "commander.helpDisplayed" ||
code === "commander.help" ||
code === "commander.version" ||
exitCode === 0
Comment on lines +260 to +261

Copilot AI Mar 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exitCode === 0 catch-all will treat any thrown error that happens to carry an exitCode: 0 property as a success and exit silently. To avoid accidentally swallowing non-Commander failures, scope this guard to Commander errors (e.g., require code to start with "commander." / check err.name === "CommanderError" / instanceof CommanderError) before exiting 0.

Suggested change
code === "commander.version" ||
exitCode === 0
code === "commander.version"

Copilot uses AI. Check for mistakes.
) {
process.exit(0);
}
const prefix = HAS_COLOR ? pc.red("Error: ") : "Error: ";
writeFileSync(2, `${prefix}${err.message}\n`);
process.exit(1);
Expand Down