Refactor/activity list filters grid by ako3131 · Pull Request #1131 · fntechgit/summit-admin

ako3131 · 2026-10-19T18:36:43Z

ref: https://app.clickup.com/t/9014802374/86bcbg72u

UI CHANGES:

Activity list now uses the MUI Data Grid: sticky column headers, drag-to-resize columns, pagination above and below the grid
Toolbar holds everything: Edit Selected, Saved Views, Add Activity, Import (MUX or CSV, one icon menu), Columns, Filters, Export, and Search (an icon that expands)
Saved Views is now a dropdown: pick, search, delete, clear, or save the current filters as a view
Columns panel replaces the "Select data to display" dropdown; every column except Actions can be hidden
Hidden default columns come back on the next visit; the optional columns you pick are remembered
Selection Status is now an optional column, hidden by default
The "All" and "All Companies" shortcuts are gone but the column selector panel Show/Hide all replaces "All"
Long cell text is cut to one line and rows grow only while being bulk-edited
A third click on a column header removes the sort and goes back to the default order

coderabbitai · 2026-10-19T18:36:55Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: c5a7d079-1f17-4c17-9ab3-7aa95580e240

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

ako3131 · 2026-10-19T18:38:41Z

/deploy-preview

github-actions · 2026-10-19T18:40:51Z

🚀 Deployed on https://pr-1131--show-admin-preview.netlify.app

Copilot

🟡 Changes recommended

Bulk-edit relationship handling and unresolved search, visibility, and keyboard interaction defects affect core activity-list workflows.

5 open issues

What changed in this PR

Migrates the activity list to MUI Data Grid and consolidates its controls into a toolbar.

Changes:

Adds resizable columns, bulk editing, and top/bottom pagination.
Introduces searchable Saved Views and optional-column persistence.
Adds grid and saved-view interaction tests.

File	Description
yarn.lock	Locks Data Grid dependencies.
src/reducers/events/event-list-reducer.js	Stores optional-column selections.
src/pages/events/summit-event-list-page/index.js	Integrates the grid and Saved Views.
src/pages/events/summit-event-list-page/helpers.js	Makes Selection Status optional.
src/pages/events/__tests__/summit-event-list-page.test.js	Tests column visibility and persistence.
src/i18n/en.json	Updates toolbar and saved-view labels.
src/components/mui/bulk-edit-data-grid.js	Adds the reusable bulk-edit grid.
src/components/mui/__tests__/bulk-edit-data-grid.test.js	Tests grid interactions.
src/components/filters/saved-views/index.js	Adds saved-view selection and management.
src/components/filters/saved-views/__tests__/saved-views.test.js	Tests saved-view workflows.
src/actions/event-actions.js	Adds the column-selection action.
package.json	Adds MUI Data Grid.

_{Review effort: Balanced}

ako3131 · 2026-10-20T00:07:45Z

+  const editField = (rowId, key, value) => {
+    setEditRows((current) => ({
+      ...current,
+      [rowId]: { ...current[rowId], [key]: value }


Fixed in d930c90

+  const loadViews = (input) =>
+    queryFilterCriterias(summitId, context, input, setViews);


ako3131 · 2026-10-20T00:07:29Z

+            onChange={handleSearch}
+            placeholder={T.translate("general.placeholders.search")}
+            // the menu otherwise treats typing as item navigation
+            onKeyDown={(ev) => ev.stopPropagation()}


Fixed in f632809

ako3131 · 2026-10-20T00:07:05Z

+      // its input and its clear button with nothing typed
+      onBlur={(ev) => {
+        if (ev.currentTarget.contains(ev.relatedTarget)) return;
+        if (!ev.currentTarget.querySelector("input").value) setExpanded(false);


Fixed in ae71970

+      field: "actions",
+      type: "actions",
+      headerName: T.translate("general.actions"),


santipalenque

hey @ako3131 good job so far!, apart from the inline comments I also found these:

columns selection not stored in view, search filter not stored in view. We should try to fix this without any API change
why is list cleared and refetch on every Saved Views dropdown open? I think we can pull in the background and avoid clearing it
some columns are not resizable (speakers), not sure if any more.

santipalenque · 2026-10-20T12:48:23Z

+    onSubmit: (values) =>
+      onSave({ id: selectedView?.id, ...values })
+        .then(() => onClose())
+        // the action's error handler reports the failure; keep the dialog


remove, unnecessary comment, this is our code standard behavior

also dialog covers API error message

santipalenque · 2026-10-20T12:49:53Z

+  };
+
+  return (
+    <Dialog


can you use uicore CustomDialog instead ? so we start standarizing dialogs

santipalenque · 2026-10-20T12:50:30Z

+  VISIBILITY_OPTION_ME
+} from "../../../utils/filter-criteria-constants";
+
+const SaveViewDialog = ({ selectedView, onSave, onClose }) => {


this should go in its own file

santipalenque · 2026-10-20T12:58:31Z

+  "& .MuiButton-startIcon": { m: 0 }
+};
+
+const renderEditor = (col, editRow, onChange) => {


please put auxiliary components in their own files following our codebase convention on directories and file org

santipalenque · 2026-10-20T13:02:01Z

+    reset();
+  }, [dataIds]);
+
+  const enterEditMode = () => {


I think we can improve UX here, wdyt about a double click in a row triggering edit mode for that row, then a blur (click outside the row) would save and escape would cancel. I think if you want to edit a single row you have to click too many times, and selecting many presentations to edit doesn't make it any easier.

santipalenque · 2026-10-20T13:04:36Z

+          onExport={handleExport}
+          searchProps={{
+            term,
+            placeholder: T.translate("general.placeholders.search"),


this should not be the generic one, we had one specific for this grid

santipalenque · 2026-10-20T13:11:43Z

+const ColumnMenu = (props) => {
+  const { colDef } = props;
+  return (
+    <GridColumnMenu


can we sort the columns alphabetically ?

santipalenque · 2026-10-20T13:22:03Z

+      name: requiredStringValidation().trim(),
+      visibility: requiredStringValidation()
+    }),
+    // keeps the id of the active view so saving updates it instead of


API doesn't allow this, please test

ako3131 · 2026-10-22T16:12:56Z

@santipalenque I made fixes according to your suggestions. However I'd like to put the double click to edit and storing search/columns in a saved view in another PR. Let me know what you think. Thank you!

santipalenque · 2026-10-23T12:05:29Z

@santipalenque I made fixes according to your suggestions. However I'd like to put the double click to edit and storing search/columns in a saved view in another PR. Let me know what you think. Thank you!

yes thats ok

santipalenque · 2026-10-23T12:07:59Z

@ako3131 I found new issues with the solution:

Pressing Enter twice in the save dialog creates duplicate views. Enter submits through Formik's handleSubmit, which doesn't block a second submit while the first is pending.
CustomDialog's guard only covers its own Save button. An early return if (formik.isSubmitting) in the form's submit handler would fix it.
Saved-views search can show stale results. queryFilterCriterias is debounced, but nothing cancels or ignores a request that is still running. If the user opens the dropdown and types
more than 500ms later, the initial unfiltered load can arrive after the search results and overwrite them. Low impact, but nobody has replied to Copilot about it.
A failed "Apply changes" still discards the user's edits. bulkUpdateEvents catches its own error, so the promise always resolves. The grid's .then(reset) then runs anyway, and its
.catch never fires. This comes from the existing action, but the new grid relies on it.
New dependency @mui/x-data-grid (7.29.13). It's the first use in summit-admin, and uicore doesn't use it either. It's worth deciding whether you accept the dependency, and whether this
grid should eventually move to uicore, since it replaces uicore's BulkEditTable.
Behavior change: Selection Status is now hidden by default. It moved from the fixed columns to the optional ones. Users only see it after turning it on in the columns panel.
Nit: at bulk-edit-data-grid/index.js:334, the "bootstrap 3 sets box-sizing…" comment sits above columnsManagement, but it explains searchInputProps further down.

santipalenque · 2026-10-23T12:19:08Z

@ako3131 more findings by using it:
1- When hiding ALL columns the grid only displays Action column, looks broken. Maybe show the select and the title always ?
2- Edit / Delete icons look too small compared to the rest of the admin

… with the top one

…the grid

…membered

…h on bulk edit

…ed inputProps

… fit text

…ave api

…a fail to make space for error

ako3131 · 2026-10-24T00:23:04Z

@santipalenque
I made fixes for your suggestions, let me know what you think.

In regards to the selection status change, I moved it to optional since it seemed like it was usually an empty column. Let me know if it should be added back.

I think it would be nice to see how it goes as a summit admin table, then potentially move it into core ui. The grid uses only the free version of @mui/x-data-grid and that provides the column resizing, sticky headers, and the columns panel.

ako3131 requested review from santipalenque and smarcet and a balanced review from Copilot October 19, 2026 18:36

ako3131 self-assigned this Oct 19, 2026

Copilot started reviewing on behalf of ako3131 October 19, 2026 18:37

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

santipalenque requested changes Oct 20, 2026

View reviewed changes

ako3131 requested a review from santipalenque October 22, 2026 16:13

ako3131 added 15 commits October 23, 2026 16:48

refactor: change activity list grid from coreui to mui data grid

2e65d86

fix: add original pagination back to the top and bottom of grid

3cdc1d3

fix: add sticky headers to the grid

39d075b

refactor: reorder grid header buttons

ddd8705

fix: move bottom pagination to under and outside of the grid to align…

bc764f1

… with the top one

refactor: add add activity and import to grid toolbar

5a90c78

refactor: move saved views into the grid toolbar

4ef2a1d

refactor: remove gap between activity list, pagination, and grid

c0db6cf

fix: increase size of import button

769b757

feat: make selection status hideable

3d1732a

fix: columns modal should show under the button not the left side of …

89c7d70

…the grid

fix: clicking the column button when the panel is open now closes it

ddc3267

fix: increase the appearance of the add button

a18160d

fix: actions column should not be able to be deselected

032e72e

fix: remove nonexistant placeholder

5b47122

ako3131 added 24 commits October 23, 2026 16:51

refactor: use ui core search not mui search in grid

33e9633

fix: match user sorted arrow displays to match previous bulk edit table

ec0c6c1

fix: use prexisting utilities

7ee23fd

fix: fix unnecessary acceptance of string in delete dialog body

924f6c1

refactor: make add activity a text button

5359bec

fix: saved views no longer briefly shows incorrect list

25297f0

fix: bring back place holder text fallback

4ea3e8b

fix: test and comment clean up

88bebe2

fix: use the preexsting general name

bb3601c

fix: all columns are hideable, defaults reset and optional one are re…

bdf606f

…membered

fix: keep grid column widths stable when resizing and truncate cell text

588d318

fix: make added columns persist when navigating away or refresh

4c0ab32

fix: speaker and selection plan persist during an activity type switc…

929fd4e

…h on bulk edit

fix: allow escape and tab keystrokes on saved views. replace deprecat…

a864eee

…ed inputProps

fix: search box collapses when it is empty and no search term applied

c66da5f

fix: add custom search placeholder and increase size of search bar to…

e6ce9e7

… fit text

fix: sort columns options by alphabetical order in column panel

d533819

fix: stop clearing list on a saved views dropdown open

e88cc0c

fix: remove update view functionality since it did not align with onS…

d1a4472

…ave api

fix: remove unneccesary comment and make saved views pop up close on …

43d6955

…a fail to make space for error

fix: use core ui dialog component for saved view pop up

e956390

fix: move save view dialog into its own file

2a536ba

fix: move tool bar buttons into their own files

d039761

fix: make sure all columns are resizable when user is not editing

0876d6c

ako3131 force-pushed the refactor/activity-list-filters-grid branch from bf2c4dc to 0876d6c Compare October 23, 2026 21:52

		const loadViews = (input) =>
		queryFilterCriterias(summitId, context, input, setViews);

Conversation

ako3131 commented Oct 19, 2026

Uh oh!

coderabbitai Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ako3131 commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

santipalenque left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ako3131 commented Oct 22, 2026

Uh oh!

santipalenque commented Oct 23, 2026

Uh oh!

santipalenque commented Oct 23, 2026

Uh oh!

santipalenque commented Oct 23, 2026

Uh oh!

ako3131 commented Oct 24, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Oct 19, 2026 •

edited

Loading