Repository navigation
Fix the sundials dylib references in the macOS package - #52
Merged
Merged
Conversation
Sundials is built with CMake, which sets the dylib install names to @rpath/libsundials_*.dylib. The install_name_tool -change commands in the packaging Makefile looked for $(PREFIX)/lib/libsundials_*.dylib as the old name, which doesn't match. Fix the old name to @rpath/ so the references are correctly rewritten to @executable_path/../Frameworks/.
tabe
force-pushed
the
fix-dmg-sundials-rpath
branch
from
October 15, 2026 07:05
59f7143 to
6ad54bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51
Sundials is built with CMake, which sets the dylib install names to @rpath/libsundials_.dylib. The install_name_tool -change commands in the packaging Makefile looked for $(PREFIX)/lib/libsundials_.dylib as the old name, which doesn't match the actual reference. This caused the references to remain as @rpath/libsundials_*.dylib with the rpath pointing to the CI build directory, leading to a crash at launch.
Fix the old name to @rpath/ so the references are correctly rewritten to @executable_path/../Frameworks/.