Repository navigation
Conversation
Extensions can configure the formatter differently depending on which other extensions are enabled (mentions only adds tag mentions while tags is enabled), but the formatter cache was only flushed when the toggled extension itself registered formatter extenders. Fixes #3758
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3758
Changes proposed in this pull request:
Toggling an extension only flushed the formatter cache when that extension registered
Extend\Formatteritself. Extensions that configure the formatter based on which other extensions are enabled were left with a stale formatter: after enabling tags,#tagwas saved as plain text, and after disabling it, replying with#tagfailed with a 500 untilphp flarum cache:clearwas run. Core now flushes the formatter whenever any extension is enabled or disabled, like it already does for the frontend assets and locale caches.Reviewers should focus on:
Enabled/Disableddirectly: the testing harness pins the enabled extensions per test case, so a real toggle can't changeisEnabled()inside a test. The tags/mentions case was checked by hand on a dev forum, both directions.cache:clearand isn't changed here.Necessity
Confirmed
composer test).