Repository navigation
fix: do not serve stale data from /data and /export - #75
Merged
Merged
Conversation
When the data file does not exist (e.g. it was removed while the server was running), data() and export() kept returning the DataFrame left in memory from an earlier request. They now return "No data available." - Reset self.df to an empty DataFrame when the data file is missing - Add a test that removes the data file and checks both endpoints Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCvw8haRnmyrVKrLkz5Yf8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Processing.data()andProcessing.export()only reloadself.dfwhen the data file exists. If the file is missing (e.g. it was removed while the server was running to start a fresh collection), both endpoints kept returning the DataFrame left in memory from an earlier request instead of reporting that no data is available.Fix
self.dfto an emptyDataFramewhen the data file does not exist, in bothdata()andexport().process()already did this./dataand/exportnow return400 No data available.in that case.Tests
TestStaleData.test_removed_data_file_is_not_served: stores a measurement, removesdata.csv, and checks both endpoints. It fails on the previous code and passes with the fix.No behaviour change when the data file exists.
Generated by Claude Code