Repository navigation
ci: skip e2e tests when only markdown files change - #291
Merged
Merged
Conversation
Add a `changes` job that detects whether a PR touches any non-markdown file and skip the E2E build/test jobs when it does not. Add a single `E2E Tests result` aggregator job that always reports, so branch rules can require it instead of the per-matrix checks (skipped matrix jobs never report their expanded check names). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015mG5hz7QECVCqv3AWMY1fi
TheUnderScorer
requested review from
a team,
ilfa,
kevinmia and
necipallef
as code owners
October 26, 2026 13:28
Contributor
pnpm exec changesetto create a changeset. |
Contributor
Coverage report
Test suite run success95 tests passing in 6 suites. Report generated by 🧪jest coverage report action from 36e2590 Show full coverage report
|
JuroUhlar
approved these changes
Oct 26, 2026
necipallef
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2E tests (Android/iOS × 4 RN versions + web) ran on every PR, including docs-only ones. This skips them when a PR changes only
.mdfiles, while keeping a required check that always reports.changesjob lists PR files via the GitHub API;code=falseonly if every file ends in.md. Non-PR events (release) always getcode=true.build-matrixande2e-tests-webrun only whencode == 'true'; Android/iOS build + test jobs skip transitively.E2E Tests resultaggregator job (if: always()): fails ifchangesfailed or any E2E job failed/cancelled; passes on success/skipped.Why not
paths-ignore/ plainif:paths-ignorestops the workflow from starting, so required checks stay "Expected" forever.... ${{ matrix.react-native }}), so per-version required checks would never resolve.A repo admin must update the
mainbranch rules: replace the per-matrix E2E required checks withE2E Tests result.Test plan
E2E Tests resultis greenE2E Tests resultgreen, PR mergeableGenerated by Claude Code