Repository navigation
chore(sdk): stop tracking sdk/README.md copy - #290
Merged
Merged
Conversation
The build copies the root README into sdk/. The committed copy went stale, so the copy dirtied the sdk package and changeset status failed in the Release workflow. Fix the .gitignore entry's case so the copy stays ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F9FmJg2Q1koTtimNRAnyfP
JuroUhlar
requested review from
a team,
TheUnderScorer,
ilfa,
kevinmia and
necipallef
as code owners
October 26, 2026 12:27
Contributor
pnpm exec changesetto create a changeset. |
Contributor
Coverage report
Test suite run success95 tests passing in 6 suites. Report generated by 🧪jest coverage report action from e9f1764 Show full coverage report
|
TheUnderScorer
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Failed Release run after #288
Why
The Release workflow fails at
changeset statusand never publishes v4.2.0, because the build overwrites a stale, committedsdk/README.md, and that change inside thesdkpackage counts as a change with no changeset.Things to note
mainwould make Release open a new release PR instead of publishing 4.2.0.copy:readmecopies it intosdk/duringprepare, as before.Verification
Locally, after running the build's
cp README.md sdk/README.md:changeset status→Some packages have been changed but no changesets were foundgit statusstays clean, andchangeset status→NO packages to be bumpedNot verified yet: the Release run on
mainafter this merges, which should publish 4.2.0.Change outline
Generated by Claude Code