Skip to content

ci: pin web e2e job to ubuntu-24.04 - #289

Merged
JuroUhlar merged 1 commit into
mainfrom
ci/pin-web-e2e-ubuntu-24-04
Oct 26, 2026
Merged

JuroUhlar merged 1 commit into
mainfrom
ci/pin-web-e2e-ubuntu-24-04

Conversation

@JuroUhlar

@JuroUhlar JuroUhlar commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Context

Failing run on #288

Why

ubuntu-latest now resolves to Ubuntu 26.04, where Playwright 1.60 can't install Chromium, so the Web E2E job fails on every branch; pinning the runner makes it pass again.

Things to note

  • Only e2e-tests-web is pinned. The other ubuntu-latest jobs don't install Playwright and pass on 26.04.

Verification

Before (on #288): pnpm exec playwright install chromium → ERROR: Playwright does not support chromium on ubuntu26.04-x64.
After: verified by this PR's Web E2E tests job.

Change outline

 # .github/workflows/e2e-tests.yml
 e2e-tests-web:
   name: Web E2E tests
-  runs-on: ubuntu-latest   # → 26.04, no Playwright Chromium
+  runs-on: ubuntu-24.04
   steps:
     ...
     - run: pnpm exec playwright install chromium

🤖 Generated with Claude Code

https://claude.ai/code/session_01F9FmJg2Q1koTtimNRAnyfP

Playwright 1.60 can't install Chromium on ubuntu-latest (now 26.04).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F9FmJg2Q1koTtimNRAnyfP
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 91.35% 243/266
🟢 Branches 87.55% 211/241
🟢 Functions 84.21% 48/57
🟢 Lines 90.98% 232/255

Test suite run success

95 tests passing in 6 suites.

Report generated by 🧪jest coverage report action from 7ab41a2

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 91.35 87.55 84.21 90.98
🟢  src 91.35 87.55 84.21 90.98
🟢   FingerprintClient.ts 100 90 100 100 22,41,54
🔴   FingerprintClient.web.ts 0 0 0 0 6-64
🟡   FingerprintContext.ts 66.66 100 0 66.66 6
🟢   FingerprintProvider.tsx 100 100 100 100
🟡   errors.ts 75 50 50 75 3,120
🟢   getOptionsCacheKey.ts 84 83.33 100 83.33 10,33,43,52
🔴   index.ts 0 0 0 0
🟢   tags.ts 95 94.44 100 95 31
🔴   types.ts 0 0 0 0
🟢   unwrapError.ts 100 88.46 100 100 18-19,40
🟢   unwrapError.web.ts 100 100 100 100
🔴   useFingerprint.ts 0 0 0 0 24-28
🟢   usePromiseStore.ts 100 100 100 100
🟢   useVisitorData.ts 95.91 85.71 90 95.74 166-167
🟢   utils.ts 98.57 97.36 90 98.48 10
🔴  src/specs 0 0 0 0
🔴   NativeRNFingerprint.ts 0 0 0 0

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Following releases will be created using changesets from this PR:

@fingerprint/react-native@4.1.0

Minor Changes

  • Updated native Fingerprint SDKs to v4.2.0 (Android and iOS). The new versions collect new raw signals for screen sharing detection, improve rooting detection on Android, and bring performance and latency improvements. (8fc5e5e)

@JuroUhlar
JuroUhlar enabled auto-merge October 26, 2026 10:46
@JuroUhlar
JuroUhlar merged commit 5e6ba8a into main Oct 26, 2026
29 checks passed
@JuroUhlar
JuroUhlar deleted the ci/pin-web-e2e-ubuntu-24-04 branch October 26, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants