Fix stale and redirecting links in the README - #253
Merged
Merged
Conversation
The SitePoint "Unraveling String Key Performance in Ruby 2.2" URL now redirects to an unrelated article, so point it at the archived original on the Wayback Machine. Update links that only worked through redirects to their final URLs: - derailed_benchmarks moved from schneems to zombocom - tenderlovemaking.com post moved to a trailing-slash path Switch the remaining http links (ruby-doc.org, Rails 5.1 guides, SitePoint) to https.
Member
Author
|
Inspered on #251 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #251. I checked every external link in the README; omniref was the only fully dead one, but a few others were stale or only worked through redirects.
Changes
schneems/derailed_benchmarks->zombocom/derailed_benchmarks(the repo moved)..htmlto a trailing-slash path.http://links (ruby-doc.org, Rails 5.1 guides, SitePoint Symbol GC) tohttps://.Verification
Each changed link returns 200 with no redirects, and the archived SitePoint page is the original article.
Not changed: the "Share this" tweet link still uses twitter.com and git.io. Both still redirect to the right place.