Repository navigation
Conversation
TYPO3 v14 lays out div.card-container as a grid of fixed-width cards. The order view wraps the comment card and the ordered items card each in their own card-container, so both shrink to card width and the items table gets cut off. The styleguide uses card-container only to group several cards in a row. Drop the wrapper around these single cards; the address and properties partials, which group several cards, keep theirs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the backend order view, the "Ordered items" card (and the order comment card) no longer spans the full width under TYPO3 v14. The items table gets cut off after a few columns.
Cause: Both cards are wrapped in their own
div.card-container. In v14 the backend lays outcard-containeras a grid of fixed-width cards. The styleguide uses it only to group several cards in a row:Change: Remove the wrapper around these two single cards in
Templates/Backend/Order/Order/Show.htmland move themb-3spacing onto the comment card. TheAddressandPropertiespartials group several cards and keep theircard-container.Markup only, no PHP changes.
Resolves: #770