Skip to content

A browser 'Subscribe' button is labelled Purchase even when it's free #378

Closed

Description

@itsskofficial

Found while testing #367. _LABEL_RULES in sentient/browser/safety.py puts subscribe under Purchase. Clicking "Subscribe to newsletter" therefore shows "Make a purchase" with "Yes, buy it" / "Don't buy" buttons. That is wrong and alarming for a free sign-up.

Purchase also drives "Purchases always ask" (rules.py, loop.py), so the fix must keep a yes for anything that may cost money.

Proposal

  • A free-looking subscribe (newsletter, updates, follow, notify me, with no price, "trial", "/month", "plan" or currency on or near the button) gets its own "Signs up" label. It still asks under the normal rules, but with honest wording.
  • Anything with price or plan signals stays Purchase and always asks.
  • Unit tests for both, plus a real check against a local page with a newsletter button and a "Subscribe – ₹499/month" button.

Activity

  1. added 2 commits that reference this issue on Oct 15, 2026
    c791c5d
    91e466f
  2. added a commit that references this issue on Oct 17, 2026
    d85dd59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area: browserBrowser controlbugSomething isn't workingpriority: P2Later: useful, lower urgencysize: SSmall: a few days

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions