Skip to content

EEBus: persist full-list writes to the remote cache - #34125

Merged
andig merged 4 commits into
masterfrom
eebus/persist-full-write
Sep 30, 2026
Merged

andig merged 4 commits into
masterfrom
eebus/persist-full-write

Conversation

@andig

@andig andig commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Fixes #34004. Upstream fix merged as enbility/eebus-go#261

Bumps the eebus-go fork to andig/eebus-go@f8d6395, which is upstream dev (including the merged fix) plus the still-open enbility/eebus-go#255 that the previous rollup already carried.

Devices that announce loadControlLimitListData as writeable without partial support receive the complete limit list on every write, merged from the locally cached remote data. The remote replaces its list with what was written, but notifies the change only after the result. writeCurrentLimitData writes OPEV, awaits the result and then writes OSCEV, so the second write was built from the stale cache and reverted the obligation just written. On the Porsche PMCC/EVSE this leaves the obligation inactive after every write, in off mode all limits inactive, and the car charges at maximum (charger logic error: disabled but charging). Same in #34066.

This surfaced in 0.316.0 because the fork rebase in #33340 pulled in enbility/eebus-go#253, which stops skipping use cases announced with useCaseAvailable=false. The PMCC announces OSCEV that way, so evcc never wrote OSCEV limits before and the two-write race never happened. Both traces in #34004 and #34066 show the PMCC notify after the OSCEV write with the OPEV ids reverted.

The upstream change persists the written list into the remote feature cache right after sending and restores the previous state if the remote rejects the write. This applies to all full-list writes (load control limits and device configuration key values), so any sequence of writes to a device without partial write support is now consistent. #34071 addresses the same symptom by writing both limit sets in a single message; both changes are independent of each other.

🤖 Generated with Claude Code

@andig andig added bug Something isn't working devices Specific device support labels Sep 27, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@andig

andig commented Sep 27, 2026

Copy link
Copy Markdown
Member Author

@uhl the idea here is to fix that upstream since imho this will be an issue for every other consumer of non-partial writes. Wdyt?

andig and others added 2 commits September 30, 2026 19:27
Rollup andig/eebus-go@f8d6395 = enbility/eebus-go dev (incl. #261) plus
the still-open #255.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@andig
andig merged commit a0a0660 into master Sep 30, 2026
14 checks passed
@andig
andig deleted the eebus/persist-full-write branch September 30, 2026 17:38
@andig

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

❌ Backport failed, most likely a cherry-pick conflict. See the run logs.

@andig

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

✅ Opened backport pull request on release/0.316.3: #34427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working devices Specific device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EEBus: Loading in smart mode active even though not enough solar power available

1 participant