Skip to content

chore: add ship-go rollup with mdns re-announcement leak fix - #32940

Merged
andig merged 1 commit into
masterfrom
chore/ship-go-rollup
Aug 18, 2026
Merged

andig merged 1 commit into
masterfrom
chore/ship-go-rollup

Conversation

@andig

@andig andig commented Aug 18, 2026

Copy link
Copy Markdown
Member

Adds a ship-go replace pointing at the andig fork rollup branch, mirroring the existing spine-go and eebus-go rollups. The branch is enbility/ship-go dev plus enbility/ship-go#109.

That PR fixes an mDNS instance leak: reannounceWithNewInterfaces cleared isAnnounced and re-announced without releasing the previous instance, so every interface change leaked one provider object. With the avahi provider these are EntryGroups, and once avahi-daemon's objects-per-client-max (1024) is reached it rejects every further allocation on that connection — including the one ResolveService needs, so no discovered service can be resolved any more.

Also fixes teardown when every interface disappears: the early isServiceAnnounced() return meant the SHIP service was never unannounced.

go test ./server/eebus/... passes.

🤖 Generated with Claude Code

Points ship-go at the andig fork rollup branch, currently enbility/ship-go dev
plus enbility/ship-go#109.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding a brief comment next to the new ship-go replace in go.mod (e.g. referencing the upstream PR or explaining the mdns leak fix) so it's clear this override is temporary and why it exists when someone later cleans up the replaces.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding a brief comment next to the new ship-go replace in go.mod (e.g. referencing the upstream PR or explaining the mdns leak fix) so it's clear this override is temporary and why it exists when someone later cleans up the replaces.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions github-actions Bot added bug Something isn't working devices Specific device support labels Aug 18, 2026
@andig
andig enabled auto-merge (squash) August 18, 2026 07:44
@andig

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

❌ pull request #32940 is not merged

@andig
andig merged commit 35ed5e5 into master Aug 18, 2026
15 checks passed
@andig
andig deleted the chore/ship-go-rollup branch August 18, 2026 07:45
@andig

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Opened backport pull request on release/0.314.2: #32941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working devices Specific device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant