Repository navigation
chore: add ship-go rollup with mdns re-announcement leak fix - #32940
Merged
Merged
Conversation
Points ship-go at the andig fork rollup branch, currently enbility/ship-go dev plus enbility/ship-go#109. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a brief comment next to the new ship-go replace in go.mod (e.g. referencing the upstream PR or explaining the mdns leak fix) so it's clear this override is temporary and why it exists when someone later cleans up the replaces.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief comment next to the new ship-go replace in go.mod (e.g. referencing the upstream PR or explaining the mdns leak fix) so it's clear this override is temporary and why it exists when someone later cleans up the replaces.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
andig
enabled auto-merge (squash)
August 18, 2026 07:44
This comment has been minimized.
This comment has been minimized.
Contributor
|
❌ pull request #32940 is not merged |
This comment has been minimized.
This comment has been minimized.
Contributor
|
✅ Opened backport pull request on |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a ship-go replace pointing at the andig fork rollup branch, mirroring the existing spine-go and eebus-go rollups. The branch is enbility/ship-go
devplus enbility/ship-go#109.That PR fixes an mDNS instance leak:
reannounceWithNewInterfacesclearedisAnnouncedand re-announced without releasing the previous instance, so every interface change leaked one provider object. With the avahi provider these areEntryGroups, and once avahi-daemon'sobjects-per-client-max(1024) is reached it rejects every further allocation on that connection — including the oneResolveServiceneeds, so no discovered service can be resolved any more.Also fixes teardown when every interface disappears: the early
isServiceAnnounced()return meant the SHIP service was never unannounced.go test ./server/eebus/...passes.🤖 Generated with Claude Code