Repository navigation
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a16bca-1655-7353-954d-3df32a86d78d Co-authored-by: Kamal Mahyuddin <kamal.fariz@gmail.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a16bca-1655-7353-954d-3df32a86d78d Co-authored-by: Kamal Mahyuddin <kamal.fariz@gmail.com>
Co-authored-by: Kamal Mahyuddin <kamal.fariz@gmail.com>
Co-authored-by: Kamal Mahyuddin <kamal.fariz@gmail.com>
kamal
marked this pull request as ready for review
October 24, 2026 02:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces CircleCI with a GitHub Actions workflow (
.github/workflows/ci.yml) and removes.circleci/and the CircleCI README badge (now a GHA badge).What CI runs now
macos-26runner, default Xcode 26.6,xcodebuild testof the Swift package (.swiftpm/xcode/package.xcworkspace, schemeJSONAPIModel) on an iPhone 17 / iOS 26.5 simulator. SwiftPM resolves SwiftyJSON 5.x.Why not Carthage +
JSONAPIModel.xcworkspacelike CircleCI didThe old path was translated literally first and no longer builds on current Xcode:
carthage bootstrapfails building SwiftyJSON 4.2.0 (pinned inCartfile.resolved) under Xcode 26 — run 40055743237.--no-build, the workspace build fails:cannot find type 'Attribute' / 'JSONAPIMap' in scope— run 40055811876. Since add tests as part of package + platform #4/disable swifty json from being exposed to consumers #6 the Xcode project is missingAttribute.swift,JSONAPIMap.swift,MetadataHelper.swift, the article fixtures/models, still usesSWIFT_VERSION = 4.2, and the tests use SwiftPM-onlyBundle.module.Package.swift(tools 6.0) is the maintained build, so CI tests that. The Carthage files,JSONAPIModel.xcworkspace/.xcodeprojand podspec (iOS 9, still 1.1.0) are left untouched; they are stale and could be removed or repaired separately.