Skip to content

Fix name normalization failing for GCC symbols with multiple periods #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LagoLunatic wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix name normalization failing for GCC symbols with multiple periods #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f9f194
Fix name normalization failing for GCC symbols with multiple periods
LagoLunatic Oct 11, 2026
8bcae7f
Update test snapshot
LagoLunatic Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion objdiff-core/src/obj/read.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ fn get_normalized_symbol_name(name: &str) -> Option<String> {
{
// Match Metrowerks symbol$1234 against symbol$2345
Some(format!("{prefix}${DUMMY_UNIQUE_ID}"))
} else if let Some((prefix, suffix)) = name.split_once('.')
} else if let Some((prefix, suffix)) = name.rsplit_once('.')
&& suffix.chars().all(char::is_numeric)
{
// Match GCC symbol.1234 against symbol.2345
Expand Down
Loading
Loading