Repository navigation
fix: use a single Generic client feature instead of typed client features (SPINE IG 3.4) - #262
Open
ckast-enqs wants to merge 2 commits into
Open
ckast-enqs wants to merge 2 commits into
ckast-enqs wants to merge 2 commits into
Conversation
…ures (SPINE IG 3.4)
Author
|
This feature is mandatory for certification, even though it is not covered in any test case. (got notified during certification process) |
Contributor
|
Can we do this for all the client use cases as well? |
Author
|
yes, i will take care of it |
…cases (SPINE IG 3.4)
Author
|
Extended to all remaining client use cases: cem/cevc, cem/evcc, cem/evcem, cem/evsecc, cem/evsoc, cem/ohpcf, cem/opev, cem/oscev, cem/vabd, cem/vapd and ma/mdt now only add a single
|
sthelen-enqs
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a single Generic client feature instead of typed client features
Problem
The SPINE IG "Protocol and Resource Guidelines" V1.0.0, §3.4 ("Uniqueness of Feature Types per Entity") requires:
The rule has no exception for the feature role. Several use cases currently violate it:
cs/lpc,cs/lpp,eg/lpc,eg/lppaddDeviceDiagnosisboth as client and as server on the same entity.ma/mgcpandma/mpcadd typed client features (DeviceConfiguration,ElectricalConnection,Measurement). When combined withcs/lpc/cs/lppon the same CEM entity, these duplicate the CS server featuresDeviceConfigurationandElectricalConnection.This was flagged during EEBUS certification in the
nodeManagementDetailedDiscoveryDataof a CEM implementing CS LPC/LPP and MA MGCP/MPC.Solution
Add one client feature of type
Genericinstead of the typed client features, as recommended by:No further changes are needed:
features/client.Featurealready falls back to the localGenericclient feature if no typed client feature exists (getLocalAndRemoteFeatures).Genericas client feature for subscriptions and bindings (subscription_manager.go,binding_manager.go).Scope
The change is intentionally minimal and limited to
cs/lpc,cs/lpp,eg/lpc,eg/lpp,ma/mgcpandma/mpc(6 files, +8/−17). Other use cases are not affected and still work when mixed (typed client features are still preferred by the fallback if present).Possible follow-ups (not part of this PR):
cem/opev,cem/oscev,cem/cevcalso addDeviceDiagnosisas client and server.cem/evccchecksresponseMsg.FeatureLocal.Type() == DeviceDiagnosisinresults.go, so it needs a logic change before switching toGeneric.Discovery before / after (CEM entity, CS LPC/LPP + MA MGCP/MPC)
Tests
go build ./...,go vet ./usecases/...andgo test ./...pass.