Skip to content

NXT-20955: React 19.3 Fragments - #456

Open
dan-ichim-lgp wants to merge 3 commits into
feature/functionalComponentsfrom
feature/NXT-20955
Open

dan-ichim-lgp wants to merge 3 commits into
feature/functionalComponentsfrom
feature/NXT-20955

Conversation

@dan-ichim-lgp

@dan-ichim-lgp dan-ichim-lgp commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

NXT-20955: Measure the ContextualPopup activator and the Dropdown list through React 19.3 Fragment refs.

Resolution

ContextualPopupDecorator and DropdownList wrap their content in <Fragment ref> and no longer render their own data-withref-target.

Popup position, direction, RTL, and flip on overflow use the union of the fragment client rects. An empty rect list is a zero box, so the holepunch scrim still receives bounds. Dropdown records the last focused item only in 5-way mode, and only while the fragment contains that target. Pointer mode does not record it.

react and react-dom are ^19.3.1. CI clones CLI and enact from feature/NXT-20955. TabGroup and Picker specs match develop again, because Spottable renders the hidden marker once more. That CI pin has to return to develop before merge.

Additional Considerations

Links

NXT-20955

Comments

Enact-DCO-1.0-Signed-off-by: Dan Ichim dan.ichim@lgepartner.com

@dan-ichim-lgp dan-ichim-lgp self-assigned this Oct 21, 2026
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.62%. Comparing base (ccf5ec6) to head (77dafaf).
⚠️ Report is 2 commits behind head on feature/functionalComponents.

Files with missing lines Patch % Lines
...ntextualPopupDecorator/ContextualPopupDecorator.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/functionalComponents     #456      +/-   ##
================================================================
+ Coverage                         83.54%   83.62%   +0.07%     
================================================================
  Files                               158      158              
  Lines                              7908     7958      +50     
  Branches                           2446     2452       +6     
================================================================
+ Hits                               6607     6655      +48     
+ Misses                             1011     1010       -1     
- Partials                            290      293       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CI clones the CLI and enact feature branches so tests run on React 19.3.
@daniel-stoian-lgp
daniel-stoian-lgp changed the base branch from develop to feature/functionalComponents October 28, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants