Repository navigation
feat: update and issue-report support for desktop tools - #31
Merged
Merged
Conversation
ui/backend/qt/update: check a GitHub release feed, download an installer with its size and SHA-256 checked, install it as a package or through the setup, and build a prefilled issue from a rotating log. Nothing in it names a product: the feed, user agent, version, issue page and log name come from the caller. Documented in doc/portability.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014WUWh4ve7wn8JxNywWbX5h
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Max errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 7 | 0 | 0 | 0.62s | ||
| ✅ CPP | clang-format | 200 | 0 | 0 | 0 | 2.0s | |
| ✅ CPP | cppcheck | 200 | 0 | 0 | 2.12s | ||
| ✅ DOCKERFILE | hadolint | 1 | 0 | 0 | 0.43s | ||
| ✅ JSON | jsonlint | 8 | 0 | 0 | 0.12s | ||
| ✅ JSON | prettier | 8 | 2 | 0 | 0 | 0.3s | |
| markdownlint | 14 | 0 | 3 | 0 | 0.92s | ||
| ✅ MARKDOWN | markdown-table-formatter | 14 | 1 | 0 | 0 | 0.16s | |
| lychee | 64 | 1 | 0 | 1.47s | |||
| ✅ YAML | prettier | 11 | 0 | 0 | 0 | 0.41s | |
| ✅ YAML | yamllint | 11 | 0 | 0 | 0.56s |
Detailed Issues
⚠️ SPELL / lychee - 1 error
📝 Summary
---------------------
🔍 Total...........23
🔗 Unique...........9
✅ Successful......15
⏳ Timeouts.........0
🔀 Redirected.......1
👻 Excluded.........7
❓ Unknown..........0
🚫 Errors...........1
⛔ Unsupported......1
Errors in .github/workflows/static-analysis.yml
[403] https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-$ (at 37:21) | Rejected status code: 403 Forbidden
Hint: Followed 1 redirect. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`
⚠️ MARKDOWN / markdownlint - 3 errors
doc/portability.md:84:171 error MD060/table-column-style Table column style [Table pipe does not align with header for style "aligned"]
doc/portability.md:89:169 error MD060/table-column-style Table column style [Table pipe does not align with header for style "aligned"]
doc/portability.md:90:169 error MD060/table-column-style Table column style [Table pipe does not align with header for style "aligned"]
Notices
REPOSITORY_GITLEAKS, REPOSITORY_KICS. See Removed linters to find their replacements.
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@10.2.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CPPCHECK,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT

Show us your support by starring ⭐ the repository
Comment on lines
+81
to
+91
| | Component | What it does | | ||
| |----------------------|-------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `ReleaseVersion` | Parses and orders `vMAJOR.MINOR.PATCH` tags | | ||
| | `ReleaseFeed` | Reads a GitHub "latest release": its version, page, every asset downloadable over HTTPS with its SHA-256, and the installer for this platform | | ||
| | `UpdateChecker` | Fetches the feed and says whether a newer release exists | | ||
| | `UpdateDownloader` | Downloads an installer next to a `.part` file, checks its size and SHA-256, and refuses an asset without a published checksum or with a path | | ||
| | `UpdateInstallation` | Tells a packaged install from a portable one and builds the command that installs an update (`apt-get` through `pkexec`, or the NSIS setup) | | ||
| | `UpdateInstaller` | Runs that command and reports whether the tool must exit first | | ||
| | `UpdateSession` | Offer, download, install, cancel and dismiss as one state machine; `SetBlocked` holds the install back while the tool is busy with hardware | | ||
| | `IssueLog` | A rotating log file plus the recent lines in memory, optionally capturing Qt's own messages | | ||
| | `IssueReport` | Builds the new-issue URL with the product, version, platform and recent log, trimmed to fit a URL | |
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| | Component | What it does | | |
| |----------------------|-------------------------------------------------------------------------------------------------------------------------------------------------| | |
| | `ReleaseVersion` | Parses and orders `vMAJOR.MINOR.PATCH` tags | | |
| | `ReleaseFeed` | Reads a GitHub "latest release": its version, page, every asset downloadable over HTTPS with its SHA-256, and the installer for this platform | | |
| | `UpdateChecker` | Fetches the feed and says whether a newer release exists | | |
| | `UpdateDownloader` | Downloads an installer next to a `.part` file, checks its size and SHA-256, and refuses an asset without a published checksum or with a path | | |
| | `UpdateInstallation` | Tells a packaged install from a portable one and builds the command that installs an update (`apt-get` through `pkexec`, or the NSIS setup) | | |
| | `UpdateInstaller` | Runs that command and reports whether the tool must exit first | | |
| | `UpdateSession` | Offer, download, install, cancel and dismiss as one state machine; `SetBlocked` holds the install back while the tool is busy with hardware | | |
| | `IssueLog` | A rotating log file plus the recent lines in memory, optionally capturing Qt's own messages | | |
| | `IssueReport` | Builds the new-issue URL with the product, version, platform and recent log, trimmed to fit a URL | | |
| | Component | What it does | | |
| |----------------------|-----------------------------------------------------------------------------------------------------------------------------------------------| | |
| | `ReleaseVersion` | Parses and orders `vMAJOR.MINOR.PATCH` tags | | |
| | `ReleaseFeed` | Reads a GitHub "latest release": its version, page, every asset downloadable over HTTPS with its SHA-256, and the installer for this platform | | |
| | `UpdateChecker` | Fetches the feed and says whether a newer release exists | | |
| | `UpdateDownloader` | Downloads an installer next to a `.part` file, checks its size and SHA-256, and refuses an asset without a published checksum or with a path | | |
| | `UpdateInstallation` | Tells a packaged install from a portable one and builds the command that installs an update (`apt-get` through `pkexec`, or the NSIS setup) | | |
| | `UpdateInstaller` | Runs that command and reports whether the tool must exit first | | |
| | `UpdateSession` | Offer, download, install, cancel and dismiss as one state machine; `SetBlocked` holds the install back while the tool is busy with hardware | | |
| | `IssueLog` | A rotating log file plus the recent lines in memory, optionally capturing Qt's own messages | | |
| | `IssueReport` | Builds the new-issue URL with the product, version, platform and recent log, trimmed to fit a URL | |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Adds
ui/backend/qt/update(ui.backend.qt.update, Qt Core + Network, built with the Qt backend), so any desktop tool can update itself from its GitHub releases and open a prefilled issue:ReleaseVersion,ReleaseFeed: the latest release, every asset downloadable over HTTPS with its SHA-256, and this platform's installer (-linux-x86_64.deb,-windows-x86_64-setup.exe).UpdateChecker,UpdateDownloader: fetch the feed; download to a.partfile and check its size and checksum.UpdateInstallation,UpdateInstaller,UpdateSession: packaged or portable, the install command (apt-getthroughpkexec, or the NSIS setup), and the offer → download → install state machine.SetBlockedholds the install back while the tool is busy.IssueLog,IssueReport: rotating log with recent lines, and the new-issue URL with product, version, platform and log.Nothing names a product: the feed URL, user agent, version, issue page and log name come from the caller. Documented under Tier 3 in
doc/portability.md.Tests: 102 new,
ctest15/15 suites pass onhost-qt.Generated by Claude Code