Repository navigation
Fix JVM tool bootstrap check with program arguments containing slashes - #4602
Merged
mergify[bot] merged 2 commits intoOct 30, 2026
Merged
mergify[bot] merged 2 commits into
mergify[bot] merged 2 commits into
Conversation
🤖 GitHub commentsJust comment with:
|
Contributor
Author
|
The PayaraIT failures came from this change: the Payara main class |
jackshirazi
approved these changes
Oct 29, 2026
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
LikeTheSalad
approved these changes
Oct 30, 2026
Contributor
✅ Merged into
|
| Condition | Required by | |
|---|---|---|
| ✅ | github-review-approved |
GitHub repository ruleset rule [org] Require a PR for Renovate, GitHub repository ruleset rule [org] Require a PR and GitHub repository ruleset rule branch protection main |
The batch, tested on draft #4613
| Condition | Required by | |
|---|---|---|
| ✅ | any of: check-success = @github-actions/build / build, check-neutral = @github-actions/build / build, check-skipped = @github-actions/build / build |
GitHub repository ruleset rule branch protection main |
| ✅ | any of: check-success = Application Server integration tests, check-neutral = Application Server integration tests, check-skipped = Application Server integration tests |
GitHub repository ruleset rule branch protection main |
| ✅ | any of: check-success = build / build, check-neutral = build / build, check-skipped = build / build |
GitHub repository ruleset rule branch protection main |
| ✅ | any of: check-success = CLA, check-neutral = CLA, check-skipped = CLA |
GitHub repository ruleset rule branch protection main |
| ✅ | any of: check-success = Non-Application Server integration tests, check-neutral = Non-Application Server integration tests, check-skipped = Non-Application Server integration tests |
GitHub repository ruleset rule branch protection main |
| ✅ | any of: check-success = Unit Tests, check-neutral = Unit Tests, check-skipped = Unit Tests |
GitHub repository ruleset rule branch protection main |
Times in UTC · dashboard · how the merge queue works
30 of 54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4269.
JvmToolBootstrapChecksplits the wholesun.java.commandvalue on/, including the program arguments. Because of this:java org.example.Main --file /my/path/file.txt, logsUnexpected JVM command line syntax.keytool -list -keystore /tmp/keystore.jks, is not detected as a JVM tool. The agent logs the same warning and instruments the tool.The check now applies the
/split to the main class or module part only, which is the first space-separated token. Commands without arguments behave as before, including the warning for unexpected main class syntax such as/my/app/Main.The tests cover a JVM tool with a path argument, with and without a module prefix, and an application with a path argument, with and without a module prefix.
Checklist