Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Exclude JRuby jobs from Windows before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds JRuby 10.0 and 10.1 to CI coverage and avoids installing pry-byebug on JRuby.
Changes:
- Expands the GitHub Actions Ruby matrix.
- Moves
pry-byebuginto a JRuby-excluded Gemfile dependency. - Documents JRuby CI coverage.
| File | Summary |
|---|---|
README.md |
Documents JRuby 10.0/10.1 CI coverage. |
net-ping.gemspec |
Removes pry-byebug from development dependencies. |
Gemfile |
Skips pry-byebug on JRuby. |
.github/workflows/test.yml |
Adds JRuby versions, but currently creates unsupported Windows JRuby jobs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eitoball
force-pushed
the
add_jruby_to_test_matrix
branch
4 times, most recently
from
September 20, 2026 22:10
d2929a4 to
ecd9da5
Compare
eitoball
force-pushed
the
add_jruby_to_test_matrix
branch
from
September 21, 2026 01:50
ecd9da5 to
4979247
Compare
byebug's C extension does not build on JRuby, so pry-byebug is moved out of the gemspec's development dependencies and into the Gemfile, guarded to skip installation on JRuby. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
eitoball
force-pushed
the
add_jruby_to_test_matrix
branch
from
September 22, 2026 02:12
4979247 to
e4f6c90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds JRuby 10.0 and 10.1 to the GitHub Actions test matrix.
Why
JRuby support wasn't covered by CI. JRuby 10.0 (Ruby 3.4 compat) and 10.1 (Ruby 4.0 compat, latest) are the currently maintained series and mirror the newest MRI versions already in the matrix.
Changes
.github/workflows/test.yml: addjruby-10.1andjruby-10.0to therubymatrixnet-ping.gemspec/Gemfile: movepry-byebugout of the gemspec's development dependencies and into the Gemfile, guarded to skip on JRuby, since byebug's C extension doesn't build there and would breakbundle installREADME.md: note that JRuby 10.0/10.1 are covered by CI