Repository navigation
feat(migrate): register transformation rules with versions - #68
Merged
Merged
Conversation
Planning now rejects an operation with an unregistered rule or a rule of another kind, and two operations for one source file. Plan documents record each rule's version, and rules and explain cover the registered rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last M6 increment under D-104. M6 is implemented once this reaches
main.migrate::rules::RULESlists every transformation rule of migrate with its version, operation kind, and summary.ruleVersion, so a rule change makes older plans stale.frameshift ruleslists the registered rules after the assessment predicates, andexplainandrules showaccept their full identifiers.Decision worth a look
Rule selection in migrate v0 is one classification function, so exclusivity holds by construction and the plan-time check is its fail-closed proof. The declarative preconditions and the feature ID index of ARCHITECTURE.md section 12 add nothing until several rules can match one occurrence, so they stay planned and are not simulated by metadata without an effect. D-104 records when to revisit this.
Test plan
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --offline --locked -- -D warningscargo test --workspace --offline --lockedpwsh -NoProfile -File .github/scripts/check.ps1RuleId's grammar, and every fixture's plan passes the checks🤖 Generated with Claude Code