Skip to content

fixed from #311, issue 2.1 - #364

Merged
rozyczko merged 2 commits into
developfrom
311-2-1-fixes
Nov 2, 2026
Merged

rozyczko merged 2 commits into
developfrom
311-2-1-fixes

Conversation

@rozyczko

Copy link
Copy Markdown
Member

Data consistency and type improvements:

  • Changed the representation of boolean fields in layer and assembly dictionaries from string values (e.g., 'True'/'False') to actual Python booleans, improving type safety and clarity (_from_layers_collection_to_list_of_dicts, _from_assemblies_collection_to_list_of_dicts, and related usages).
  • Updated the layers property and related functions to use more precise type annotations, reflecting the inclusion of boolean values.

Minimizer and Bayesian logic refactoring:

  • Refactored minimizer selection logic to simplify the list of available minimizers, clarify the handling of the Bayesian option, and ensure correct index mapping between GUI and backend.
  • Exposed VALID_INITIALIZERS for Bayesian sampling as a public constant and updated all references to use it, ensuring consistency between frontend options and backend validation.

Parameter filtering and display improvements:

  • Simplified experiment/model parameter filtering by using the explicit parameter['experiment'] field instead of helper methods, reducing indirection and potential errors.
  • Improved logic for generating parameter display names, especially for layer and magnetism parameters, by refining path handling and helper functions.

Plot rendering and result handling:

  • Updated Bayesian plot property methods to clarify that plots are rendered after sampling finishes, not on property read, and removed unnecessary on-demand rendering logic.

Other codebase cleanups:

  • Improved the add_new method in layers logic to return whether a new material was added, increasing transparency for the caller.
  • Added missing imports and clarified type annotations for better code clarity and reliability.

@rozyczko rozyczko added [scope] bug Bug report or fix (major.minor.PATCH) [priority] high Should be prioritized soon labels Oct 29, 2026
@rozyczko
rozyczko merged commit 0e73f6d into develop Nov 2, 2026
28 checks passed
@rozyczko
rozyczko deleted the 311-2-1-fixes branch November 2, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] high Should be prioritized soon [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant