Repository navigation
fix(analyzers): keep escaped braces literal in the E128015 fix - #175
Merged
Merged
Conversation
- scan the format string into literal runs, so doubled braces stay in one text token - escape source syntax in Text and keep the format content in ValueText - add regression tests for escaped braces alone and beside a placeholder - update the code fix output lode note and drop the redundant AnalysisMode lines Co-Authored-By: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executive Summary
The E128015 code fix emitted a broken interpolated string when the format string held doubled braces. The scanner split each brace pair into two
InterpolatedStringTextTokennodes, so{{x}}became{then{in the emitted source and changed the runtime value. The fix now scans literal runs: doubled braces stay inside one text token, with escaped source syntax inTextand the original content inValueText.Code Changes
StringFormatToInterpolationCodeFixProviderwalks the format string as literal runs between placeholders.ProcessOpenBraceandProcessLiteralTextcollapse intoProcessPlaceholderandAddLiteralText.CreateTextContentkeeps escaped source syntax inTextand the format content inValueText, which is what the binder consumes.E128.Analyzerspackage.Tests and Tooling
StringFormat_EscapedBraces_StayLiteralandStringFormat_EscapedBracesBesidePlaceholder_StayLiteraltoStringFormatToInterpolationE128CodeFixTests.scripts/check.sh --allpassed: shell lint, format check, build, and test.Review Guide
StringFormatToInterpolationCodeFixProvider.BuildInterpolatedString: confirm the literal-run boundaries.CreateTextContent: confirm theTextandValueTextsplit.Rollback
Revert the commit. The fix only widens which format strings the fixer accepts, so reverting restores the old behavior without touching analyzer diagnostics.
Links
🤖 Generated with Claude Code