Repository navigation
fix(analyzers): correct six review findings and close the plan - #171
Merged
Merged
Conversation
- E128223: resolve this.field to the field, so two process fields stay distinct - E128014: offer no fix for a multi-atom body; the brace rewrite kept the report - E128224: treat Position writes as writes; analyze target-typed creations - E128226: analyze target-typed creations - E128227: drop the type-wide MaxResponseContentBufferSize trust - tests: route eight classes through the shared runner; add CompilationSettings - plans: remove the resolved 2026-11-14 review plan - bump E128.Analyzers to 3.1.3 Co-Authored-By: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executive Summary
Fixes the six Medium findings that the resolved 2026-11-14 review plan left unapplied, and removes the completed plan. Each defect was confirmed against source before the edit.
E128223:this.fieldresolved to the containing type, so a wait on one process field bound a redirect set on another field.E128014: the code fix rewrote a multi-atom outer quantifier to{1,}, which the rule still reports. The fixer now offers no action for that shape.E128224: an assignment or increment toPositioncounted as a read. Target-typednew(...)was not analyzed.E128226: target-typednew(...)was not analyzed.E128227: anyMaxResponseContentBufferSizemention in the type silenced every read. It caps client buffering only, so it no longer bounds a direct content read.AnalyzerTestRunnerandCodeFixTestRunner, with newCompilationSettingsandCodeFixTestOptionshelpers.Code Changes
ProcessLaunchScope.GetRootSymbolresolves athis/basemember access to the member symbol and a type-qualified chain to its innermost member.GeneratedRegexNestedCodeFixProviderrewrites single-atom bodies only.ReadOnlyMemoryStreamAnalyzerandComparerSetConstructionAnalyzerregisterImplicitObjectCreationExpression.HttpBodyReadWithoutSizeBoundAnalyzerdropsTypeBoundNames/text matching; only a bound in the read scope counts.Tests and Tooling
scripts/check.sh --all: shell, format, build, and tests pass. 3001 tests, 2999 passed, 2 skipped (pre-existing).scripts/internal/analyzer-release-check.sh --json: clean.scripts/readme-table-diff.sh --analyzer --json: no drift.scripts/internal/analyzer-promote.sh --json: empty, because this release adds no rule rows.Positionwrite, and both target-typed creations.Review Guide
Start with the two behavior changes:
ProcessLaunchScope.GetRootSymboland its test inHandRolledProcessCaptureAnalyzerTests.HttpBodyReadWithoutSizeBoundAnalyzer.HasSizeBound; E128227 now reports reads under a same-type client cap.The test-runner refactor is mechanical and covered by the existing suite.
Rollback
Revert this commit. No data, schema, or public API change. The only user-visible behavior change is the E128227 report scope.
🤖 Generated with Claude Code