Skip to content

fix(analyzers): correct six review findings and close the plan - #171

Merged
e128 merged 1 commit into
mainfrom
fix/analyzer-review-medium-findings
Nov 16, 2026
Merged

e128 merged 1 commit into
mainfrom
fix/analyzer-review-medium-findings

Conversation

@e128

@e128 e128 commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Executive Summary

Fixes the six Medium findings that the resolved 2026-11-14 review plan left unapplied, and removes the completed plan. Each defect was confirmed against source before the edit.

  • E128223: this.field resolved to the containing type, so a wait on one process field bound a redirect set on another field.
  • E128014: the code fix rewrote a multi-atom outer quantifier to {1,}, which the rule still reports. The fixer now offers no action for that shape.
  • E128224: an assignment or increment to Position counted as a read. Target-typed new(...) was not analyzed.
  • E128226: target-typed new(...) was not analyzed.
  • E128227: any MaxResponseContentBufferSize mention in the type silenced every read. It caps client buffering only, so it no longer bounds a direct content read.
  • Eight test classes bypassed the shared runner. They now route through AnalyzerTestRunner and CodeFixTestRunner, with new CompilationSettings and CodeFixTestOptions helpers.

Code Changes

  • ProcessLaunchScope.GetRootSymbol resolves a this/base member access to the member symbol and a type-qualified chain to its innermost member.
  • GeneratedRegexNestedCodeFixProvider rewrites single-atom bodies only.
  • ReadOnlyMemoryStreamAnalyzer and ComparerSetConstructionAnalyzer register ImplicitObjectCreationExpression.
  • HttpBodyReadWithoutSizeBoundAnalyzer drops TypeBoundNames/text matching; only a bound in the read scope counts.
  • Analyzer version bumped 3.1.2 to 3.1.3. README install version follows.
  • Lode rule details updated for E128014, E128224, E128226, and E128227.

Tests and Tooling

  • scripts/check.sh --all: shell, format, build, and tests pass. 3001 tests, 2999 passed, 2 skipped (pre-existing).
  • scripts/internal/analyzer-release-check.sh --json: clean.
  • scripts/readme-table-diff.sh --analyzer --json: no drift.
  • scripts/internal/analyzer-promote.sh --json: empty, because this release adds no rule rows.
  • Tests added for the two-field process case, the Position write, and both target-typed creations.

Review Guide

Start with the two behavior changes:

  1. ProcessLaunchScope.GetRootSymbol and its test in HandRolledProcessCaptureAnalyzerTests.
  2. HttpBodyReadWithoutSizeBoundAnalyzer.HasSizeBound; E128227 now reports reads under a same-type client cap.
    The test-runner refactor is mechanical and covered by the existing suite.

Rollback

Revert this commit. No data, schema, or public API change. The only user-visible behavior change is the E128227 report scope.

🤖 Generated with Claude Code

- E128223: resolve this.field to the field, so two process fields stay distinct
- E128014: offer no fix for a multi-atom body; the brace rewrite kept the report
- E128224: treat Position writes as writes; analyze target-typed creations
- E128226: analyze target-typed creations
- E128227: drop the type-wide MaxResponseContentBufferSize trust
- tests: route eight classes through the shared runner; add CompilationSettings
- plans: remove the resolved 2026-11-14 review plan
- bump E128.Analyzers to 3.1.3

Co-Authored-By: Claude
@e128
e128 merged commit 58a177e into main Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant