Repository navigation
fix(analyzers): accept capped token overload and trace delete paths - #170
Merged
Merged
Conversation
E128227 accepts LoadIntoBufferAsync(long, CancellationToken) and still rejects the token-only and parameterless overloads. E128184 treats new DirectoryInfo(path) as carrying path provenance, and traces a private helper parameter to its call sites in the same type part. The two resolved register captures are removed, and E128.Analyzers moves to 3.1.2. Co-Authored-By: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executive Summary
Two analyzer defects filed in the analyzer-candidates register are fixed.
LoadIntoBufferAsync(long), which carries no token, so CA2016, MA0040, and S8949 reject it.Code Changes
LoadIntoBufferAsynccall whose first parameter islong, with or without a trailingCancellationToken. The token-only and parameterless overloads still do not bound a read.new DirectoryInfo(path)as carrying the safety ofpath.Tests and Tooling
DirectoryInfoover a rooted literal reports.scripts/check.sh --allpassed: shell, format, build, and test.Review Guide
src/E128.Analyzers/Security/HttpBodyReadWithoutSizeBoundAnalyzer.cs: cap overload shape.src/E128.Analyzers/Security/RecursiveDeleteRootAnalyzer.cs:ClassifyDirectoryInfoCreation,ClassifyParameter,ClassifyCallSites.lode/dotnet/analyzers/rule-details.md,rule-details-security.md: current-state rule contracts.Rollback
Revert the commit. The analyzer behavior returns to the 3.1.1 shape. No migration or data change.
🤖 Generated with Claude Code